Skip to content

Revert "Add ShitGiftHook hook on ethereum" (0x0f7f…, PR #580)#585

Merged
marktoda merged 1 commit into
mainfrom
revert-shitgifthook-0x0f7ff748
May 27, 2026
Merged

Revert "Add ShitGiftHook hook on ethereum" (0x0f7f…, PR #580)#585
marktoda merged 1 commit into
mainfrom
revert-shitgifthook-0x0f7ff748

Conversation

@marktoda
Copy link
Copy Markdown
Contributor

Summary

Reverts #580.

The submitter (@dogeshitmeme, author of issue #579) asked twice for PR #580 to be closed before it was merged:

The hook at 0x0f7ff748F58D16876BA71783F3a7cF2Cf3f2C040 was deployed but never used (no pool initialized; zero on-chain interactions since deployment). It was abandoned in favor of a Future-RANDAO queue-model redesign.

The live production hook for this project is deployed at 0xEf2dEBE958d3d3B8Cb8Bf489961BDDf23ca20040 (verified on Etherscan, submitted in #581 / PR #582).

Issue #579 was closed by the submitter as superseded. The close-request comments arrived after the bot's APPROVED review fired, and the triage fast-path didn't surface them before merge — apologies on that. PR #582 (the production deploy at 0xEf2dEBE9…) is the one we want to keep.

regenerate.yml will rebuild hooklist.json on merge to drop the stale entry.

Test plan

  • validate.yml passes (file removal, no schema changes)
  • regenerate.yml runs on merge and removes the 0x0f7f entry from hooklist.json

@vercel
Copy link
Copy Markdown

vercel Bot commented May 25, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hooklist Ready Ready Preview, Comment May 27, 2026 6:44pm

Request Review

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: hooks/ethereum/0x0f7ff748f58d16876ba71783f3a7cf2cf3f2c040.json

Contract: ShitGiftHook (verified source, ethereum mainnet, chainId 1)

Flags

Address ends in c040 hex = 1100 0000 0100 0000 binary. Bits 0–13: 00 0000 0100 0000. Only bit 6 (afterSwap) is set. This matches getHookPermissions() in the source exactly. All flag values in the JSON are correct. ✓

Properties

  • dynamicFee: false — No lpFeeOverride returned from beforeSwap (beforeSwap is not even enabled), and no poolManager.updateDynamicLPFee() calls anywhere in the source. ✓
  • upgradeable: false — No proxy patterns, no delegatecall, no mutable implementation pointer, no SELFDESTRUCT. All config is set via immutables in the constructor. ✓
  • requiresCustomSwapData: false — The hookData parameter in afterSwap is explicitly ignored (bytes calldata /* hookData */). Swaps function normally with empty hookData. ✓
  • vanillaSwap: false — Correct. The hook's afterSwap performs an external ERC-20 safeTransfer of 1 ether of an art token to tx.origin on winning rolls. This is beyond mere observation/event emission and changes the economic outcome of the transaction. ✓
  • swapAccess: "none" — The hook has no beforeSwap (disabled in permissions; stub reverts with "unsupported" which PoolManager would never call). afterSwap only enforces msg.sender == POOL_MANAGER, which is standard for all hooks, not an access-control gate on swaps. ✓

Metadata

  • verifiedSource: true — Confirmed by source_meta.json ("verified": true). ✓
  • chainId: 1 — Ethereum per chains.json. ✓
  • name: "ShitGiftHook" — Matches contractName from source_meta.json. No promotional, audit, or endorsement language. ✓
  • description — All claims are substantiated by the Solidity source: MIN_BUY = 42069 ether, DROP_CHANCE_BPS = 100 (1% roll), DROP_COOLDOWN = 1 days (24h per-origin cooldown), CEI ordering (state writes before external transfer), FACTORY.isValidToken gate at deposit, ERC-20/ERC-1155 dual-surface deposit paths, tx.origin as recipient. No audit claims or marketing language. ✓

All fields verified. LGTM.

This reverts commit 1d423c1 (PR #580).

The submitter (@dogeshitmeme, who opened issue #579) requested PR #580 be
closed before it was merged: the hook at
0x0f7ff748F58D16876BA71783F3a7cF2Cf3f2C040 was deployed but never used
(no pool initialized, zero on-chain interactions) and was abandoned in
favor of a Future-RANDAO queue-model redesign deployed at
0xEf2dEBE958d3d3B8Cb8Bf489961BDDf23ca20040 (PR #582, already on main).

Issue #579 was closed by the submitter as superseded. The close-request
comments arrived after the bot's APPROVED review and were not surfaced
to the triage fast-path before merge.

regenerate.yml will rebuild hooklist.json on merge to drop the stale entry.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@marktoda marktoda force-pushed the revert-shitgifthook-0x0f7ff748 branch from cf76a8e to c6794ca Compare May 27, 2026 18:44
@marktoda marktoda merged commit 047922f into main May 27, 2026
7 checks passed
@marktoda marktoda deleted the revert-shitgifthook-0x0f7ff748 branch May 27, 2026 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant