Revert "Add ShitGiftHook hook on ethereum" (0x0f7f…, PR #580)#585
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Review: hooks/ethereum/0x0f7ff748f58d16876ba71783f3a7cf2cf3f2c040.json
Contract: ShitGiftHook (verified source, ethereum mainnet, chainId 1)
Flags
Address ends in c040 hex = 1100 0000 0100 0000 binary. Bits 0–13: 00 0000 0100 0000. Only bit 6 (afterSwap) is set. This matches getHookPermissions() in the source exactly. All flag values in the JSON are correct. ✓
Properties
- dynamicFee: false — No
lpFeeOverridereturned from beforeSwap (beforeSwap is not even enabled), and nopoolManager.updateDynamicLPFee()calls anywhere in the source. ✓ - upgradeable: false — No proxy patterns, no
delegatecall, no mutable implementation pointer, noSELFDESTRUCT. All config is set via immutables in the constructor. ✓ - requiresCustomSwapData: false — The
hookDataparameter inafterSwapis explicitly ignored (bytes calldata /* hookData */). Swaps function normally with empty hookData. ✓ - vanillaSwap: false — Correct. The hook's
afterSwapperforms an external ERC-20safeTransferof 1 ether of an art token totx.originon winning rolls. This is beyond mere observation/event emission and changes the economic outcome of the transaction. ✓ - swapAccess: "none" — The hook has no
beforeSwap(disabled in permissions; stub reverts with "unsupported" which PoolManager would never call).afterSwaponly enforcesmsg.sender == POOL_MANAGER, which is standard for all hooks, not an access-control gate on swaps. ✓
Metadata
- verifiedSource: true — Confirmed by
source_meta.json("verified": true). ✓ - chainId: 1 — Ethereum per
chains.json. ✓ - name: "ShitGiftHook" — Matches
contractNamefrom source_meta.json. No promotional, audit, or endorsement language. ✓ - description — All claims are substantiated by the Solidity source:
MIN_BUY = 42069 ether,DROP_CHANCE_BPS = 100(1% roll),DROP_COOLDOWN = 1 days(24h per-origin cooldown), CEI ordering (state writes before external transfer),FACTORY.isValidTokengate at deposit, ERC-20/ERC-1155 dual-surface deposit paths,tx.originas recipient. No audit claims or marketing language. ✓
All fields verified. LGTM.
3 tasks
This reverts commit 1d423c1 (PR #580). The submitter (@dogeshitmeme, who opened issue #579) requested PR #580 be closed before it was merged: the hook at 0x0f7ff748F58D16876BA71783F3a7cF2Cf3f2C040 was deployed but never used (no pool initialized, zero on-chain interactions) and was abandoned in favor of a Future-RANDAO queue-model redesign deployed at 0xEf2dEBE958d3d3B8Cb8Bf489961BDDf23ca20040 (PR #582, already on main). Issue #579 was closed by the submitter as superseded. The close-request comments arrived after the bot's APPROVED review and were not surfaced to the triage fast-path before merge. regenerate.yml will rebuild hooklist.json on merge to drop the stale entry. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
cf76a8e to
c6794ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts #580.
The submitter (@dogeshitmeme, author of issue #579) asked twice for PR #580 to be closed before it was merged:
Issue #579 was closed by the submitter as superseded. The close-request comments arrived after the bot's APPROVED review fired, and the triage fast-path didn't surface them before merge — apologies on that. PR #582 (the production deploy at
0xEf2dEBE9…) is the one we want to keep.regenerate.ymlwill rebuildhooklist.jsonon merge to drop the stale entry.Test plan
validate.ymlpasses (file removal, no schema changes)regenerate.ymlruns on merge and removes the 0x0f7f entry fromhooklist.json