Skip to content

test: enforce deps deduplication #4097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zzmp merged 11 commits into from
Jul 13, 2022
Merged

test: enforce deps deduplication #4097

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
55549ce
build: use fewer babel versions
zzmp Jul 13, 2022
df8b4db
build: dedup
zzmp Jul 13, 2022
edfa3f4
test: test deps dedups
zzmp Jul 13, 2022
09b1f74
Merge remote-tracking branch 'uni/main' into dedup
zzmp Jul 13, 2022
26e5ee6
fix: test.yml
zzmp Jul 13, 2022
2ca16c4
fix: typo
zzmp Jul 13, 2022
5f972e0
test: failing
zzmp Jul 13, 2022
8852944
fix: dedup
zzmp Jul 13, 2022
05baaa8
fix: dedup
zzmp Jul 13, 2022
c58559c
test: comment dedup tests
zzmp Jul 13, 2022
6fbe612
chore: whitespace
zzmp Jul 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,17 @@ jobs:
- uses: actions/checkout@v3
- uses: ./.github/actions/setup
- run: yarn lint

deps-tests:
Copy link
Copy Markdown
Contributor

@vm vm Jul 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we may wanna explain to users what to do when this fails somehow

runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: ./.github/actions/setup
# Test that deps satisfy both "fewer" and "highest" strategies. This is to ensure we are
# up-to-date ("highest") while avoiding increasing package size ("fewer").
# These are readonly (--list) and explicitly exclude packages which only satisfy one strategy.
- run: npx yarn-deduplicate --strategy=fewer --list --fail --exclude commander safe-buffer
- run: npx yarn-deduplicate --strategy=highest --list --fail --exclude commander safe-buffer

unit-tests:
runs-on: ubuntu-latest
Expand Down
Loading