-
Notifications
You must be signed in to change notification settings - Fork 5.4k
test(e2e): attempt to de-flake #6611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #6611 +/- ##
==========================================
+ Coverage 60.14% 60.74% +0.60%
==========================================
Files 719 719
Lines 21155 21155
Branches 6980 6980
==========================================
+ Hits 12723 12851 +128
+ Misses 8356 8229 -127
+ Partials 76 75 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
1 flaky tests on run #11142 ↗︎Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Swap > Swap on main page > swaps ETH for USDC |
Output
Screenshots
Video
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
| if (results && results.video) { | ||
| // If there were no failures (including flakes), delete the recorded video. | ||
| if (!results.tests?.some((test) => test.attempts.some((attempt) => attempt?.state === 'failed'))) { | ||
| unlinkSync(results.video) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was surprised to see the node std lib called in here. Are there docs for this pattern you could link to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, but I don't know that it's worth linking to in the cypress config: cypress-io/cypress#16377
| // Set slippage to a high value. | ||
| cy.get(getTestSelector('open-settings-dialog-button')).click() | ||
| cy.get(getTestSelector('max-slippage-settings')).click() | ||
| cy.get(getTestSelector('slippage-input')).clear().type('5') | ||
| cy.get('body').click('topRight') | ||
| cy.get(getTestSelector('slippage-input')).should('not.exist') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the slippage setting here to avoid flake I encountered related to network slippage--are you sure about this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran this about 10 times and the only flake I got was in swapping, not here.
Description
Simplifies tests in an attempt to de-flake them.
Test plan
Automated testing