-
Notifications
You must be signed in to change notification settings - Fork 5.4k
feat: MP closes on scroll down #6682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: MP closes on scroll down #6682
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Passing run #12772 ↗︎Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
|
Tested this on my iphone and I'm seeing some issues. The sensitivity seems to be a bit off which causes some jittery behavior. If the app is registering my gesture to pull down the sheet, the sheet should track the movement of my finger. In the second video, you can also see that sometimes the content in the sheet will get stuck in a scrolled state. |
zzmp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Can you just add comments within the useGesture so it's more apparent what the logic there is doing?
cartcrom
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm unfortunately still getting the scrolling/sliding at the same time behaviour I sent to you on slack, on mobile chrome and safari
Description
Adds features to have Mini Portfolio close when users on mobile scroll down.
Adds an event listener to
AccountDrawerto see if a user swipes down and if so, will triggertoggleWalletDrawerto close the Mini Portfolio.Linear ticket: WEB-1801
Screen capture
Before
Screen.Recording.2023-06-01.at.3.40.12.PM.mov
After
Screen.Recording.2023-06-02.at.3.24.56.PM.mov
Test plan
QA (ie manual testing)
Automated testing