Skip to content

Conversation

@just-toby
Copy link
Contributor

@just-toby just-toby commented Jun 2, 2023

Description

upgrades the coned package to get this change: Uniswap/conedison#19

Test plan

Reproducing the error

  1. Try to sign a permit2 signature with trustwallet ios on optimism or arbitrum - it will fail without this change.

QA (ie manual testing)

  • manually moved this change into interface and tested it , it works as a fallback

@vercel
Copy link

vercel bot commented Jun 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
interface ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 2, 2023 4:15pm
interface-node18 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 2, 2023 4:15pm

Copy link
Contributor Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@socket-security
Copy link

New dependency changes detected. Learn more about Socket for GitHub ↗︎


👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

🚮 Removed packages: @uniswap/conedison@1.5.3

@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Patch coverage has no change and project coverage change: +1.23 🎉

Comparison is base (02c0dee) 58.99% compared to head (4022852) 60.23%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6688      +/-   ##
==========================================
+ Coverage   58.99%   60.23%   +1.23%     
==========================================
  Files         731      733       +2     
  Lines       21434    21491      +57     
  Branches     7079     7095      +16     
==========================================
+ Hits        12645    12945     +300     
+ Misses       8718     8470     -248     
- Partials       71       76       +5     
Flag Coverage Δ
e2e-tests 60.29% <ø> (-1.26%) ⬇️
unit-tests 22.75% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 71 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cypress
Copy link

cypress bot commented Jun 2, 2023

Passing run #11593 ↗︎

0 69 8 0 Flakiness 0

Details:

feat: upgrade conedison
Project: Uniswap Interface Commit: 402285289c
Status: Passed Duration: 04:45 💡
Started: Jun 2, 2023 4:20 PM Ended: Jun 2, 2023 4:24 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@just-toby just-toby requested review from JFrankfurt and cartcrom June 2, 2023 16:27
@just-toby just-toby merged commit 0c5d915 into main Jun 2, 2023
@just-toby just-toby deleted the feat/coned-upgrade-6-2 branch June 2, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants