use single call to get token information #855
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/uniswap/uniswap-frontend/f3cmzlmbi |
|
Deploy preview for uniswap ready! Built with commit 52bbabd |
Contributor
Author
done |
NoahZinsmeister
approved these changes
Jun 4, 2020
crisog
pushed a commit
to Levinswap/levinswap-interface
that referenced
this pull request
Feb 5, 2021
* use single call to get token information * delete the bytes32 overload * console log statement * add a bunch of tests to actions.ts for multicall * fix to work with bytes32 symbols/names * only include name/symbol * enforce lowercase calldata
daniel-dev1990
pushed a commit
to daniel-dev1990/uniswap-interface
that referenced
this pull request
Jul 8, 2021
* use single call to get token information * delete the bytes32 overload * console log statement * add a bunch of tests to actions.ts for multicall * fix to work with bytes32 symbols/names * only include name/symbol * enforce lowercase calldata
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i think bytes32 returndata if decoded as a string will probably work fine