With #120 complete I'm now thinking that if we took this idea further we could also support abilities that grant entire preset abilities if certain conditions are passed.
Example: https://wahapedia.ru/wh40k10ed/factions/thousand-sons/#Kindred-Sorcery
MALEVOLENT CHARGE
Psychic weapons equipped by THOUSAND SONS models from your army have the [LETHAL HITS] ability.
PSYCHIC MAELSTROM
Psychic weapons equipped by THOUSAND SONS models from your army have the [SUSTAINED HITS 1] ability.
WRATH OF THE IMMATERIUM
Psychic weapons equipped by THOUSAND SONS models from your army have the [DEVASTATING WOUNDS] ability.
So in this example the condition is handled by the work done in #120, we would "just" need to add a new modifier effect that can effectively grant an entire weapon ability for the current attack. Said weapon ability would need to be chosen from a list of preset options.
Adding such an effect would also make it available as an unconditional effect which I think is just confusing so I think we'd need this effect to be the first that actually requires a condition - so some validation work to be done here as well as adjust the odd bit of help text to suit.
With #120 complete I'm now thinking that if we took this idea further we could also support abilities that grant entire preset abilities if certain conditions are passed.
Example: https://wahapedia.ru/wh40k10ed/factions/thousand-sons/#Kindred-Sorcery
So in this example the condition is handled by the work done in #120, we would "just" need to add a new modifier effect that can effectively grant an entire weapon ability for the current attack. Said weapon ability would need to be chosen from a list of preset options.
Adding such an effect would also make it available as an unconditional effect which I think is just confusing so I think we'd need this effect to be the first that actually requires a condition - so some validation work to be done here as well as adjust the odd bit of help text to suit.