Improve Azure ACR evidence gates#1240
Open
lcwLcw123 wants to merge 1 commit into
Open
Conversation
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1206.
This improves
skills/cloud/azure-reviewby adding supplemental Azure Container Registry gates for admin account state, public/private network posture, Private Link/DNS evidence, identity/RBAC scope, repository-scoped tokens, Defender image scanning, and retention controls.Changes included:
AcrPush/AcrDelete, missing Defender scanning evidence, and missing private DNS/build-agent reachability evidence.benchmark-checklist.mdwith ACR-REG-1 through ACR-REG-5 checks.AcrPulland a vulnerable public/admin-enabled registry with broadAcrPush.Validation
rg -n "ACR Evidence|ACR-REG|azurerm_container_registry|admin_enabled|network_rule_bypass_option|repository-scoped token|Defender image scanning|Container Registry Private Link|AcrPush" skills/cloud/azure-review -Sgit diff --checkgit diff --cached --checkskills/**/SKILL.mdBounty