Add PCI TPSP AOC service coverage gates#1720
Open
DENGXUELIN wants to merge 1 commit into
Open
Conversation
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skill Improvement ($50-150 Bounty)
Skill Modified
Skill name: pci-dss-review
Skill path:
skills/compliance/pci-dss-review/What Was Wrong
The PCI DSS review skill did not force reviewers to prove that a third-party service provider AOC actually covers the exact consumed payment service before reducing merchant scope. That can miss cases where a provider AOC is current but excludes hosted fields, payment-page scripts, token vaults, webhook handling, or the specific PCI DSS requirements the merchant still owns.
What This PR Fixes
This PR adds TPSP responsibility and AOC service-coverage gates that require:
Evidence
Before (skill misses this / false positive on this):
After (now correctly handled):
Test Cases Added/Updated
tests/vulnerable/)tests/benign/)Added:
skills/compliance/pci-dss-review/tests/vulnerable/tpsp-aoc-service-mismatch.mdskills/compliance/pci-dss-review/tests/benign/outsourced-hosted-page-current-aoc.mdValidation performed locally:
git merge-tree --write-tree origin/main HEADgit diff --check origin/main...HEADBounty Tier
Bounty Info
Closes #1607