Skip to content

Conversation

@IDKWNTCMF
Copy link
Collaborator

No description provided.

auto iterator = targets.find(sourceFilePath);
bool externFromStub =
iterator != targets.end() &&
CollectionUtils::contains(stubGen.getStubSources(iterator->second),sourceFilePath);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not formatted

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactored

Linker linker{testGen, stubGen, lineInfo, generator};
linker.prepareArtifacts();
auto testMethods = linker.getTestMethods();
auto successfulTargets = linker.getSuccessfulTargets();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bad naming

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed to selectedTargets

@IDKWNTCMF IDKWNTCMF requested a review from ladisgin August 9, 2023 14:12
@IDKWNTCMF IDKWNTCMF merged commit 38de4ee into main Aug 9, 2023
@IDKWNTCMF IDKWNTCMF deleted the fix-unresolved-reference-to branch August 9, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

undefined reference to {wrapper_name} while --fvisibility=hidden is present Trying to extern variables from wrapper files without linking with them

3 participants