Skip to content

Remove name generation logic from CgVariableConstructor#1797

Merged
EgorkaKulikov merged 1 commit intomainfrom
egor/name_generation_incapsulated
Feb 15, 2023
Merged

Remove name generation logic from CgVariableConstructor#1797
EgorkaKulikov merged 1 commit intomainfrom
egor/name_generation_incapsulated

Conversation

@EgorkaKulikov
Copy link
Collaborator

Description

Name generation in codegen is the responsibility of NameGenerator.
This logic should not be implemented in CgVariableConstructor. API of this class reduced.

How to test

Automated tests

Running utbot-sample pipeline is enough for regression checks.
No new logic in PR.

Self-check list

  • I've set the proper labels for my PR (at least, for category and component).
  • PR title and description are clear and intelligible.
  • I've added enough comments to my code, particularly in hard-to-understand areas.
  • The functionality I've repaired, changed or added is covered with automated tests.
  • Manual tests have been provided optionally.
  • The documentation for the functionality I've been working on is up-to-date.

@EgorkaKulikov EgorkaKulikov added comp-codegen Issue is related to code generator ctg-refactoring Issue related to refactoring process labels Feb 15, 2023
@EgorkaKulikov EgorkaKulikov requested a review from Damtev February 15, 2023 11:24
@EgorkaKulikov EgorkaKulikov merged commit f25dcc9 into main Feb 15, 2023
@EgorkaKulikov EgorkaKulikov deleted the egor/name_generation_incapsulated branch February 15, 2023 12:08
@alisevych alisevych added this to the 2023.03 Release milestone Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp-codegen Issue is related to code generator ctg-refactoring Issue related to refactoring process

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments