Exception is thrown on IDE shutdown #211#212
Closed
Vassiliy-Kudryashov wants to merge 1 commit intomainfrom
Closed
Exception is thrown on IDE shutdown #211#212Vassiliy-Kudryashov wants to merge 1 commit intomainfrom
Vassiliy-Kudryashov wants to merge 1 commit intomainfrom
Conversation
Vassiliy-Kudryashov
requested review from
EgorkaKulikov
and removed request for
denis-fokin
denis-fokin
reviewed
Jun 16, 2022
| private fun staticsMockingConfigured(): Boolean { | ||
| val entries = ModuleRootManager.getInstance(model.testModule).modifiableModel.contentEntries | ||
| val modifiableModel = ModuleRootManager.getInstance(model.testModule).modifiableModel | ||
| Disposer.register(disposable) { modifiableModel.dispose() } |
Collaborator
There was a problem hiding this comment.
Will be the disposable disposed on the window close?
Member
Author
Vassiliy-Kudryashov
deleted the
Vassiliy-Kudryashov/211-exception-is-thrown-on-ide-shutdown
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Obtained ModifiableRootModel should be disposed or committed, otherwise the resource is considered as 'leaked'
Fixes #211
Type of Change
How Has This Been Tested?
Manual Scenario
No exception should be seen in log
Checklist (remove irrelevant options):