Make spring-analyzer bean post processor distinguish 3 kinds of beans: @Component-like beans, @Bean-like beans, and XML-like beans#2178
Merged
EgorkaKulikov merged 1 commit intomainfrom Apr 25, 2023
Conversation
EgorkaKulikov
approved these changes
Apr 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make it so 3 main kinds of beans are treated separately when it comes to determining their type:
@Component-like beans we can get the type by simply looking at the annotated class@Bean-like beans we have to analyze the method defining bean (for now, we actually run it)beanClassNameThis pull request is relevant because the approach used earlier failed for
@Bean-like beans defined with a static method. It returned type of the@Configurationclass defining the bean instead of type of the bean itself . For instance, in the following example for beanbeanLogBeanFactoryPostProcessorwe gotWebConfigurationas its type instead ofLogBeanFactoryPostProcessor.How to test
Manual tests
Generate tests for Spring projects using all 3 kinds of beans.
Self-check list