Skip to content

Remove classId comparison for UtCompositeModel#2193

Merged
EgorkaKulikov merged 2 commits intomainfrom
egor/correct_compositemodels_comparison
May 2, 2023
Merged

Remove classId comparison for UtCompositeModel#2193
EgorkaKulikov merged 2 commits intomainfrom
egor/correct_compositemodels_comparison

Conversation

@EgorkaKulikov
Copy link
Collaborator

Description

We expect that UtCompositeModel.id is unique in execution.
So additional comparison on classId is not necessary.

How to test

Automated tests

utbot-samples pipeline as a set of regression checks

Manual tests

Some regression in Spring codegen is possible.

Self-check list

  • I've set the proper labels for my PR (at least, for category and component).
  • PR title and description are clear and intelligible.
  • I've added enough comments to my code, particularly in hard-to-understand areas.
  • The functionality I've repaired, changed or added is covered with automated tests.
  • Manual tests have been provided optionally.
  • The documentation for the functionality I've been working on is up-to-date.

@EgorkaKulikov EgorkaKulikov added ctg-enhancement New feature, improvement or change request comp-symbolic-engine Issue is related to the symbolic execution engine labels May 2, 2023
@EgorkaKulikov EgorkaKulikov requested a review from Damtev May 2, 2023 10:49
@EgorkaKulikov EgorkaKulikov merged commit d18b2ac into main May 2, 2023
@EgorkaKulikov EgorkaKulikov deleted the egor/correct_compositemodels_comparison branch May 2, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp-symbolic-engine Issue is related to the symbolic execution engine ctg-enhancement New feature, improvement or change request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants