Go. Big update #2206
Merged
Go. Big update #2206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egiptipavel
added
ctg-enhancement
Markoutte
approved these changes
May 23, 2023
| }, | ||
| modify = Routine.ForEach(listOf(chanType.elementTypeId!!)) { self, i, values -> | ||
| val model = self as GoUtChanModel | ||
| if (i >= model.value.size) { |
Collaborator
There was a problem hiding this comment.
Isn't this check always false?
| object GoNilValueProvider : ValueProvider<GoTypeId, GoUtModel, GoDescription> { | ||
| override fun accept(type: GoTypeId): Boolean = type is GoSliceTypeId || type is GoMapTypeId | ||
| override fun accept(type: GoTypeId): Boolean = | ||
| type is GoSliceTypeId || type is GoMapTypeId || type is GoChanTypeId || type is GoPointerTypeId || type is GoInterfaceTypeId |
Collaborator
There was a problem hiding this comment.
setOf(...).any(...) would be easier to ready
| construct = Routine.Create(listOf(pointerType.elementTypeId!!)) { values -> | ||
| GoUtPointerModel(value = values.first(), typeId = pointerType) | ||
| }, | ||
| modify = sequenceOf(Routine.Call(listOf(pointerType.elementTypeId)) { self, values -> |
Collaborator
There was a problem hiding this comment.
Look likes this duplicates the logic from the construct and the sequence can be empty in this case
| }, | ||
| modify = Routine.ForEach(listOf(sliceType.elementTypeId!!)) { self, i, values -> | ||
| val model = self as GoUtSliceModel | ||
| if (i >= model.length) { |
Collaborator
There was a problem hiding this comment.
Same as before: do we really need this check?
|
|
||
| fun modifyEnvironment(goExecutableAbsolutePath: Path, gopathAbsolutePath: Path): MutableMap<String, String> { | ||
| val environment = System.getenv().toMutableMap().apply { | ||
| this["Path"] = goExecutableAbsolutePath.parent.toString() + File.pathSeparator + (this["Path"] ?: "") |
Collaborator
There was a problem hiding this comment.
Path.resolve(String other) can be used here
| cell(allFunctionExecutionTimeoutSecondsSpinner) | ||
| cell(JBLabel("seconds")) | ||
| } | ||
| row("Number of fuzzing processes:") { |
Collaborator
There was a problem hiding this comment.
Should a user know about this number?
Collaborator
Author
There was a problem hiding this comment.
I think this is important if he wants to run fuzzing instead of generating tests.
Markoutte
requested changes
May 25, 2023
| fun modifyEnvironment(goExecutableAbsolutePath: Path, gopathAbsolutePath: Path): MutableMap<String, String> { | ||
| val environment = System.getenv().toMutableMap().apply { | ||
| this["Path"] = goExecutableAbsolutePath.parent.toString() + File.pathSeparator + (this["Path"] ?: "") | ||
| this["Path"] = goExecutableAbsolutePath.resolve(File.pathSeparator).toString() + (this["Path"] ?: "") |
Collaborator
There was a problem hiding this comment.
Resolve should resolve a child element of the current path.
Markoutte
approved these changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added support for new types:
Changed test generation template
Added support for methods
Parallel fuzzing
Traces -> coverage
Fixes #2117
How to test
Manual tests
Test on
utbot-go/go-samples/simple/samples.goandutbot-go/go-samples/simple/supported_types.gofiles.Self-check list