Skip to content

Conversation

@Markoutte
Copy link
Collaborator

Description

During soot initialization an engine process uses 2 options: UtSettings.removeUtBotClassesFromHierarchy and UtSettings.removeSootClassesFromHierarchy. They both are implemented through RdSettingsContainer#settingsFor. To improve speed the values of these options were extracted into separate variables before the loop.

You can find more details in this comment.

How to test

No specific tests are required.

Self-check list

  • I've set the proper labels for my PR (at least, for category and component).
  • PR title and description are clear and intelligible.
  • I've added enough comments to my code, particularly in hard-to-understand areas.
  • The functionality I've repaired, changed or added is covered with automated tests.
  • Manual tests have been provided optionally.
  • The documentation for the functionality I've been working on is up-to-date.

@Markoutte Markoutte added ctg-enhancement New feature, improvement or change request spec-performance Performance-related issue labels Aug 29, 2023
@Vassiliy-Kudryashov Vassiliy-Kudryashov merged commit 042d42c into main Aug 30, 2023
@Vassiliy-Kudryashov Vassiliy-Kudryashov deleted the pelevin/extract-options-to-prevent-rd-comm branch August 30, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ctg-enhancement New feature, improvement or change request spec-performance Performance-related issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants