Skip to content

Conversation

@Saloed
Copy link
Collaborator

@Saloed Saloed commented Feb 6, 2025

Some implementations of JarEntry are inner classes referencing their JarFiles for doing some internal checks,e.g., on getting input stream. Such caching may require the JarFiles to always be open. To address the issue, copies of all JarEntries should be cached.

Some implementations of JarEntry are inner classes referencing their JarFiles
for doing some internal checks,e.g., on getting input stream. Such caching
may require the JarFiles to always be open. To address the issue, copies
of all JarEntries should be cached.
@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2025

Lifecycle test results

78 tests  ±0   78 ✅ ±0   1m 26s ⏱️ -1s
 7 suites ±0    0 💤 ±0 
 7 files   ±0    0 ❌ ±0 

Results for commit f725afa. ± Comparison against base commit ad9d047.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2025

Test results on JDK 19

 72 files  ±0   72 suites  ±0   4m 34s ⏱️ -9s
628 tests +1  618 ✅ +1  10 💤 ±0  0 ❌ ±0 
698 runs  +1  688 ✅ +1  10 💤 ±0  0 ❌ ±0 

Results for commit f725afa. ± Comparison against base commit ad9d047.

@codecov
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 69.43%. Comparing base (ad9d047) to head (f725afa).
Report is 1 commits behind head on neo.

Files with missing lines Patch % Lines
...db-core/src/main/kotlin/org/jacodb/impl/fs/Jars.kt 33.33% 0 Missing and 2 partials ⚠️
...c/main/kotlin/org/jacodb/impl/util/SequenceUtil.kt 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                neo     #303      +/-   ##
============================================
- Coverage     69.43%   69.43%   -0.01%     
- Complexity     2474     2475       +1     
============================================
  Files           271      271              
  Lines         15450    15455       +5     
  Branches       2282     2284       +2     
============================================
+ Hits          10728    10731       +3     
  Misses         3791     3791              
- Partials        931      933       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2025

Test results on JDK 8

 72 files  ±0   72 suites  ±0   4m 47s ⏱️ +3s
628 tests +1  615 ✅ +1  13 💤 ±0  0 ❌ ±0 
698 runs  +1  685 ✅ +1  13 💤 ±0  0 ❌ ±0 

Results for commit f725afa. ± Comparison against base commit ad9d047.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2025

Test results on JDK 11

 72 files  ±0   72 suites  ±0   5m 16s ⏱️ +4s
628 tests +1  620 ✅ +1  8 💤 ±0  0 ❌ ±0 
698 runs  +1  690 ✅ +1  8 💤 ±0  0 ❌ ±0 

Results for commit f725afa. ± Comparison against base commit ad9d047.

@Saloed Saloed merged commit f66dd8c into neo Feb 6, 2025
10 of 11 checks passed
@Saloed Saloed deleted the saloed/fix-jar-loader branch February 6, 2025 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants