[jacodb-storage, jacodb-core] Move pluggable caches to jacodb-storage #304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pluggable caches API moved to the jacodb-storage-api module, implementations are in the jacodb-storage module. The jacodb-storage module has compileOnly dependencies on the libraries providing caches. So to use caches without dependency on the jacodb-core module, one should define particular dependency of the caching library, Guava or Xodus.
Contributor
Contributor
Contributor
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## neo #304 +/- ##
============================================
- Coverage 69.43% 69.19% -0.24%
+ Complexity 2475 2474 -1
============================================
Files 271 269 -2
Lines 15455 15441 -14
Branches 2284 2281 -3
============================================
- Hits 10731 10685 -46
- Misses 3791 3829 +38
+ Partials 933 927 -6 ☔ View full report in Codecov by Sentry. |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pluggable caches API moved to the jacodb-storage-api module, implementations are in the jacodb-storage module. The jacodb-storage module has compileOnly dependencies on the libraries providing caches. So to use caches without dependency on the jacodb-core module, one should define particular dependency of the caching library, Guava or Xodus.