Add call/field resolver, disable AA type inference#264
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+570
to
+571
|
|
||
| // Perfect signature: |
Check warning
Code scanning / detekt
Reports methods that have an empty first line. Warning
| val clazz = classes.single() | ||
| return clazz.fields.single { it.name == field.name } | ||
| } | ||
| val fields = classes.flatMap { it.fields.filter { it.name == field.name } } |
Check warning
Code scanning / detekt
Disallow shadowing variable declarations. Warning
| val fields = classes.flatMap { it.fields.filter { it.name == field.name } } | ||
| if (fields.size == 1) return fields.single() | ||
| } else { | ||
| val fields = ctx.scene.projectAndSdkClasses.flatMap { it.fields.filter { it.name == field.name } } |
Check warning
Code scanning / detekt
Disallow shadowing variable declarations. Warning
CaelmBleidd
approved these changes
Feb 26, 2025
Saloed
pushed a commit
that referenced
this pull request
Jun 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds simple (yet better than it was before) call/field resolver.
Also, we decided to turn off ArkAnalyzer's type inference in order to test and evaluate our SE engine more carefully in situation when most of the value have unknown types. Known types are beneficial, but currently we might unconsciously rely on their presence too much. Fixing the issues with call/field resolver in this PR allowed to pass the test suite we already have. If necessary, AA's type inference can be enable via an option during the scene loading.