Replaced access path bases with access paths in backward dataflow#282
Merged
Replaced access path bases with access paths in backward dataflow#282
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
094d735 to
3f5fdde
Compare
Lipen
requested changes
Jun 24, 2025
Member
|
For the future reference: this PR disrupted the "saved types" trick for handling Below is the failing test with unresolved class CaseNew2 {
entrypoint() {
let x = new Something(); // unresolved
let y = x.foo; // use 'foo' field
this.infer(x);
}
infer(a: any): any {
const EXPECTED_ARG_0 = "Something { foo: any }";
}
} |
Lipen
approved these changes
Jul 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced nested objects in backward dataflow with access paths, also get a performance increase.