Skip to content

Fix release Docker workflow: remove SHA tags, fix manifest attestation digest#76

Merged
JaredHatfield merged 2 commits intomainfrom
copilot/fix-docker-pull-tag
Mar 29, 2026
Merged

Fix release Docker workflow: remove SHA tags, fix manifest attestation digest#76
JaredHatfield merged 2 commits intomainfrom
copilot/fix-docker-pull-tag

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 29, 2026

GHCR UI displays sha-f873d2e as the default pull command instead of v1.3.0, and the manifest attestation step fails with subject-digest must be in the format "sha256:<hex-digest>" because the digest extraction returns null.

Changes

  • Remove type=sha from metadata tags in both build-and-push and manifest jobs — unnecessary for a release workflow that already produces semver tags (v1.3.0, v1.3, v1, latest)

  • Fix digest extraction in the manifest job — the old command piped JSON through jq -r '.Digest' but there is no top-level Digest field; the digest lives at .Manifest.Digest in Go template / .manifest.digest in JSON:

- DIGEST=$(docker buildx imagetools inspect "${IMAGE}:${META_VERSION}" --format '{{json .}}' | jq -r '.Digest')
+ DIGEST=$(docker buildx imagetools inspect "${IMAGE}:${META_VERSION}" --format '{{.Manifest.Digest}}')

This returns sha256:<hex> directly, matching what actions/attest-build-provenance expects for subject-digest.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

…rkflow

- Remove type=sha from build-and-push and manifest metadata tags so
  GHCR shows semver tags (e.g., v1.3.0) as the default pull command
  instead of SHA-based tags (e.g., sha-f873d2e)
- Fix digest extraction in manifest job: replace broken
  `jq -r '.Digest'` (returned null) with Go template
  `--format '{{.Manifest.Digest}}'` for correct sha256 digest output
  required by actions/attest-build-provenance

Agent-Logs-Url: https://github.com/UnitVectorY-Labs/hellorest/sessions/8a30df2f-7014-4c9f-aaa7-3174d2965099

Co-authored-by: JaredHatfield <208119+JaredHatfield@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix docker pull tag for container image Fix release Docker workflow: remove SHA tags, fix manifest attestation digest Mar 29, 2026
Copilot AI requested a review from JaredHatfield March 29, 2026 16:12
@JaredHatfield JaredHatfield marked this pull request as ready for review March 29, 2026 16:48
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (f873d2e) to head (f1c0735).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main     #76   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          1       1           
  Lines         17      17           
=====================================
  Misses        17      17           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JaredHatfield JaredHatfield merged commit 38a7783 into main Mar 29, 2026
5 checks passed
@JaredHatfield JaredHatfield deleted the copilot/fix-docker-pull-tag branch March 29, 2026 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants