Skip to content

fix: remove --project/--location flags, vertex top-level config, and GEOPENPROXY references#3

Merged
JaredHatfield merged 4 commits into
mainfrom
copilot/remove-gcp-parameters-and-renames
May 14, 2026
Merged

fix: remove --project/--location flags, vertex top-level config, and GEOPENPROXY references#3
JaredHatfield merged 4 commits into
mainfrom
copilot/remove-gcp-parameters-and-renames

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 13, 2026

Summary

This PR addresses several cleanup items identified in the codebase:

Changes

Remove --project and --location CLI flags

  • These were GCP-specific parameters that added confusion since the app is not GCP-specific
  • Removed from main.go flag parsing and printHelp()
  • Removed Project and Location fields from the Flags struct in config.go

Remove vertex: top-level config section

  • The Vertex VertexConfig field in Config is now tagged yaml:"-" so it is no longer loaded from the YAML config file
  • Project/location are still populated from GCP environment variables (GOOGLE_CLOUD_PROJECT, CLOUDSDK_CORE_PROJECT, GOOGLE_CLOUD_LOCATION, etc.) for backward compatibility
  • The internal VertexBaseURL() method continues to work for GCP backends

Fix startup failure when project is not configured

  • Removed the validation check that returned an error (--project is required) when no GCP project was set
  • The app now starts successfully without any project configured; individual backend requests that require a project will fail at request time rather than preventing startup

Fix GEOPENPROXYLOCALMODELPROXY references

  • docs/USAGE.md had three references to GEOPENPROXY_CONFIG (the prototype name) — all updated to LOCALMODELPROXY_CONFIG

Remove project/location from startup output

  • Removed project= and location= from the plain/jsonl startup log line in ui.go
  • Removed the Project/Location row from the TUI display

Tests

  • Updated config tests to remove use of removed Flags.Project and vertex: YAML
  • Added TestLoadsWithoutProject to explicitly verify the app starts when no project is configured
  • All existing tests pass

…GEOPENPROXY references

Agent-Logs-Url: https://github.com/UnitVectorY-Labs/localmodelproxy/sessions/4687168e-2fe1-45cb-b273-e6597ed756fd

Co-authored-by: JaredHatfield <208119+JaredHatfield@users.noreply.github.com>
@JaredHatfield JaredHatfield marked this pull request as ready for review May 14, 2026 01:04
@JaredHatfield JaredHatfield merged commit 4bb2763 into main May 14, 2026
3 checks passed
@JaredHatfield JaredHatfield deleted the copilot/remove-gcp-parameters-and-renames branch May 14, 2026 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants