Memory leaks when pm2 updated to 3.4.0 or later version

[liujiede]

Memory leaks in 3.4.0 and later versions

each request will be an instance of new Meter.js

Call chain

• node_modules/@pm2/io/build/main/index.js

const pmx_1 = require("./pmx");
const IO_KEY = Symbol.for('@pm2/io');
const isAlreadyHere = (Object.getOwnPropertySymbols(global).indexOf(IO_KEY) > -1);

• node_modules/@pm2/io/build/main/pmx.js

        this.actionService.init();
        serviceManager_1.ServiceManager.set('actions', this.actionService);
        this.metricService = new metrics_1.MetricService();

• node_modules/@pm2/io/build/main/metrics/httpMetrics.js

    hookRequire() {
        this.hooks = requireMiddle(['http', 'https'], (exports, name) => {
            this.hookHttp(exports, name);
            return exports;
        });
    }

    if (event !== 'request')
                    return original.apply(this, arguments);
                if (name === 'http') {
                    self.registerHttpMetric();
                }

• node_modules/@pm2/io/build/main/utils/metrics/meter.js

    this._interval = setInterval(function () {
      self._rate.tick();
    }, this._tickInterval);
    this._interval.unref();

Simple test case

//test.js
const http = require('http');
http.createServer(function(req, res){
  res.end('okay');
}).listen(8080)

1、run by ./node_modules/.bin/pm2-dev start ./test.js

2、request http://127.0.0.1:8080

as the amount of requests increases, the cpu will eventually skyrocket and memory leaks

[ZhangDianPeng]

I also encountered this problem when updated to 3.5.1.

[rchl]

Is that with @pm2/io >= 4.2.2?

[liujiede]

Is that with @pm2/io >= 4.2.2?

---

Seems to be >=4.2.1
 

no problem

private hookRequire () {
    //...
    shimmer.wrap(Module, '_load', function (original: Function) {
      return function (file) {
        // we first require the target module
        const returned = original.apply(original, arguments)
        // if it's a modue that we want to patch, install the patch on top of it
        if (file === 'http' && self.modules['http'] === undefined) {
          self.registerHttpMetric()
          self.hookHttp(returned, file)
        } else if (file === 'https' && self.modules['https'] === undefined) {
          self.registerHttpsMetric()
          self.hookHttp(returned, file)
        }
        // and of course send the module so user can use it
        return returned
      }
    })
    //...
  }

problematic

 private hookRequire () {
    this.hooks = requireMiddle(['http', 'https'], (exports, name) => {
      this.hookHttp(exports, name)
      return exports
    })
  }

[Eywek]

You can reproduce with 4.2.2?

[pengpwang]

I also encountered this problem when updated to pm2@3.5.1.

[hedgeday]

I encountered the problem when I updated to 3.5.1, but can't seem to reproduce with 3.5.0.

[rchl]

Version of pm2 doesn't really matter as the problem is/was in @pm2/io package and installing any recent version of pm2 always installs latest version of @pm2/io.

The bug might be fixed already in latest version of @pm2/io btw. I'm still verifying that.

[HughePaul]

Is there a way to disable the HTTP and HTTPS intercepts completely? This is causing memory and CPU runaway in production at the moment

[rchl]

Memory leak is fixed as long as your pm2 is using @pm2/io >= 4.2.2

[wizardpisces]

Also this problem when updated to pm2@3.5.1, downgrade to pm2@3.2.2 fixed the leak for now

[hodoublesy]

I am still seeing CPU and Memory usage stair-step up even on 4.2.3 - going to try downgrading pm2@3.2.2 to see if it fixes this.

[maxfadeev]

@hodoublesy, did that help you ?