Skip to content

Fixed the valid TRS test failing due to variable not being initialized to the identity matrix in RTShadows (1220600). #1100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 3, 2020
Merged

Fixed the valid TRS test failing due to variable not being initialized to the identity matrix in RTShadows (1220600). #1100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc4f320
Fixed the valid TRS test failing due to variable not being initialize…
anisunity Jul 2, 2020
e0079b7
Merge branch '8.x.x/hd/staging' into 8.x.x/hd/fix-rtshadows-validtrs
sebastienlagarde Jul 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions com.unity.render-pipelines.high-definition/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fixed missing include guards in shadow hlsl files.
- Fixed issue with light layers bigger than 8 (and above the supported range).
- Fixed an issue where decals were duplicated in prefab isolation mode.
- Fixed issue with light layers bigger than 8 (and above the supported range).
- Fixed the valid TRS test failing due to variable not being initialized to the identity matrix in RTShadows (1220600).

### Changed
- Shadowmask and realtime reflection probe property are hide in Quality settings
Expand Down
2 changes: 1 addition & 1 deletion com.unity.render-pipelines.high-definition/Runtime/Lighting/Light/HDAdditionalLightData.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1430,7 +1430,7 @@ internal int shadowPrecision
Plane[] m_ShadowFrustumPlanes = new Plane[6];

// temporary matrix that stores the previous light data (mainly used to discard history for ray traced screen space shadows)
[System.NonSerialized] internal Matrix4x4 previousTransform = new Matrix4x4();
[System.NonSerialized] internal Matrix4x4 previousTransform = Matrix4x4.identity;
// Temporary index that stores the current shadow index for the light
[System.NonSerialized] internal int shadowIndex = -1;

Expand Down