Skip to content

Fix an issue with dynamic resolution handler in case no OnResolutionChange callback is defined #1403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 24, 2020
Merged

Fix an issue with dynamic resolution handler in case no OnResolutionChange callback is defined #1403

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc64394
Fix issue
FrancescoC-unity Jul 24, 2020
a0dfdbc
Changelog
FrancescoC-unity Jul 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions com.unity.render-pipelines.core/Runtime/Common/DynamicResolutionHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,8 @@ public void Update(GlobalDynamicResolutionSettings settings, Action OnResolution
ScalableBufferManager.ResizeBuffers(m_CurrentFraction, m_CurrentFraction);
}

OnResolutionChange();
if(OnResolutionChange != null)
OnResolutionChange();
}
else
{
Expand All @@ -169,7 +170,8 @@ public void Update(GlobalDynamicResolutionSettings settings, Action OnResolution
if(ScalableBufferManager.widthScaleFactor != m_PrevHWScaleWidth ||
ScalableBufferManager.heightScaleFactor != m_PrevHWScaleHeight)
{
OnResolutionChange();
if (OnResolutionChange != null)
OnResolutionChange();
}
}
}
Expand Down
1 change: 1 addition & 0 deletions com.unity.render-pipelines.high-definition/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -750,6 +750,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fixed a missing dependecy for choosing to evaluate transparent SSR.
- Fixed issue that failed compilation when XR is disabled.
- Fixed a compilation error in the IES code.
- Fixed issue with dynamic resolution handler when no OnResolutionChange callback is specified.

### Changed
- Improve MIP selection for decals on Transparents
Expand Down