[8.x.x] Add exit 0 to mklink command on Android automated builds #1552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
This PR adds
exit 0tomklinkcommand part for NDK, JDK and SDK on android platforms.Unity-downloader-cli does not download NDK, JDK and SDK with Unity, hence we were adding those with bokken image and then symlinking them into the project. Soon downloader-cli will be updated to include those, once that is done this command will exit with non 0 code and fail yamato test run. This PR prevents that. After new change is made
mklinkcommands will be removed entirely.Backport for #1548
Testing status
Automated Tests:
Yamato tests to make sure it does not break current builds
Yamato: (Select your branch):
https://yamato.prd.cds.internal.unity3d.com/jobs/902-Graphics/tree/android%252Fmklink-exit0
Any test projects to go with this to help reviewers?
This PR does not change anything inside projects themselves
Comments to reviewers
None