use unique package artifact paths #1557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 27 commits
August 6, 2020 09:31
kivistikliis
changed the title
# Conflicts: # .yamato/ruamel/jobs/packages/package_test.py # .yamato/ruamel/jobs/shared/constants.py
kivistikliis
changed the title
sophiaaar
approved these changes
Aug 10, 2020
kivistikliis
pushed a commit
that referenced
this pull request
Aug 10, 2020
* cherrypick: packages path fix (#1045) (missing backport from release branches to master) * try copy * change path * mkdir * copy artifacts together * remove quotes * use %%x as in batch file * add temp publish_shadergraph --dry-run to test publishing with new paths * mac cmd * fix macos mkdir * add artifacts-path to publish and promote, add shadergraph dryrun publish/promote * add copy to publish * mkdir publish * add missing copycmd * test dependencies cmd * remove artifacts path from promote * add promote copy .json back * use constant for temp path, update templates pack path * undo artifact path *.tgz endings # Conflicts: # .yamato/ruamel/jobs/packages/package_pack.py # .yamato/ruamel/jobs/packages/package_test.py # .yamato/ruamel/jobs/shared/constants.py # .yamato/ruamel/jobs/shared/yml_job.py
kivistikliis
pushed a commit
that referenced
this pull request
Aug 10, 2020
* cherrypick: packages path fix (#1045) (missing backport from release branches to master) * try copy * change path * mkdir * copy artifacts together * remove quotes * use %%x as in batch file * add temp publish_shadergraph --dry-run to test publishing with new paths * mac cmd * fix macos mkdir * add artifacts-path to publish and promote, add shadergraph dryrun publish/promote * add copy to publish * mkdir publish * add missing copycmd * test dependencies cmd * remove artifacts path from promote * add promote copy .json back * use constant for temp path, update templates pack path * undo artifact path *.tgz endings
kivistikliis
pushed a commit
that referenced
this pull request
Aug 11, 2020
* cherrypick: packages path fix (#1045) (missing backport from release branches to master) * try copy * change path * mkdir * copy artifacts together * remove quotes * use %%x as in batch file * add temp publish_shadergraph --dry-run to test publishing with new paths * mac cmd * fix macos mkdir * add artifacts-path to publish and promote, add shadergraph dryrun publish/promote * add copy to publish * mkdir publish * add missing copycmd * test dependencies cmd * remove artifacts path from promote * add promote copy .json back * use constant for temp path, update templates pack path * undo artifact path *.tgz endings
kivistikliis
pushed a commit
that referenced
this pull request
Aug 11, 2020
* cherrypick: packages path fix (#1045) (missing backport from release branches to master) * try copy * change path * mkdir * copy artifacts together * remove quotes * use %%x as in batch file * add temp publish_shadergraph --dry-run to test publishing with new paths * mac cmd * fix macos mkdir * add artifacts-path to publish and promote, add shadergraph dryrun publish/promote * add copy to publish * mkdir publish * add missing copycmd * test dependencies cmd * remove artifacts path from promote * add promote copy .json back * use constant for temp path, update templates pack path * undo artifact path *.tgz endings
sophiaaar
pushed a commit
that referenced
this pull request
Aug 11, 2020
* [Yamato] pass UPM_REGISTRY var to mac minis (#1354) * [Yamato] add promote/publish dry run jobs (#1480) * promote dry run jobs * publish dryrun jobs * let promote dryrun use publish dryrun * [Packages][Yamato] Use project context for package jobs (#1546) * project context jobs * fix platform names * fix names * bump package versions * refactor jobs * publish_all job * promote jobs [project context] * turn off nightly trigger for old package publish jobs * all 'test all' job and turn off trigger for old job * fix duplicated dependencies * add publish dry runs * add promotion dry run jobs # Conflicts: # .yamato/_packages.yml # .yamato/_preview_publish.yml # .yamato/ruamel/jobs/packages/package_test_all.py * [Yamato] Package publish_all with and without tagging (#1555) * publish_all with and without tagging * Update _packages.yml * add tagging/no-tagging jobs for project context * edit job names and remove agent from publish job Co-authored-by: Sophia <sophia@unity3d.com> * [Yamato][Packages] Use unique package artifact paths (#1557) * cherrypick: packages path fix (#1045) (missing backport from release branches to master) * try copy * change path * mkdir * copy artifacts together * remove quotes * use %%x as in batch file * add temp publish_shadergraph --dry-run to test publishing with new paths * mac cmd * fix macos mkdir * add artifacts-path to publish and promote, add shadergraph dryrun publish/promote * add copy to publish * mkdir publish * add missing copycmd * test dependencies cmd * remove artifacts path from promote * add promote copy .json back * use constant for temp path, update templates pack path * undo artifact path *.tgz endings * [Yamato][Packages] Use unique package artifact paths (#1557) * cherrypick: packages path fix (#1045) (missing backport from release branches to master) * try copy * change path * mkdir * copy artifacts together * remove quotes * use %%x as in batch file * add temp publish_shadergraph --dry-run to test publishing with new paths * mac cmd * fix macos mkdir * add artifacts-path to publish and promote, add shadergraph dryrun publish/promote * add copy to publish * mkdir publish * add missing copycmd * test dependencies cmd * remove artifacts path from promote * add promote copy .json back * use constant for temp path, update templates pack path * undo artifact path *.tgz endings * [Yamato] add missing commands to core package test (#1561) * add missing commands to core * let abv use project context
sophiaaar
pushed a commit
that referenced
this pull request
Aug 11, 2020
* [Yamato] pass UPM_REGISTRY var to mac minis (#1354) * [Yamato] add promote/publish dry run jobs (#1480) * promote dry run jobs * publish dryrun jobs * let promote dryrun use publish dryrun * [Packages][Yamato] Use project context for package jobs (#1546) * project context jobs * fix platform names * fix names * bump package versions * refactor jobs * publish_all job * promote jobs [project context] * turn off nightly trigger for old package publish jobs * all 'test all' job and turn off trigger for old job * fix duplicated dependencies * add publish dry runs * add promotion dry run jobs * [Yamato][Packages] Use unique package artifact paths (#1557) * cherrypick: packages path fix (#1045) (missing backport from release branches to master) * try copy * change path * mkdir * copy artifacts together * remove quotes * use %%x as in batch file * add temp publish_shadergraph --dry-run to test publishing with new paths * mac cmd * fix macos mkdir * add artifacts-path to publish and promote, add shadergraph dryrun publish/promote * add copy to publish * mkdir publish * add missing copycmd * test dependencies cmd * remove artifacts path from promote * add promote copy .json back * use constant for temp path, update templates pack path * undo artifact path *.tgz endings * [Yamato] add missing commands to core package test (#1561) * add missing commands to core * let abv use project context
sophiaaar
pushed a commit
that referenced
this pull request
Aug 12, 2020
* [Yamato] pass UPM_REGISTRY var to mac minis (#1354) * [Yamato] add promote/publish dry run jobs (#1480) * promote dry run jobs * publish dryrun jobs * let promote dryrun use publish dryrun * [Packages][Yamato] Use project context for package jobs (#1546) * project context jobs * fix platform names * fix names * bump package versions * refactor jobs * publish_all job * promote jobs [project context] * turn off nightly trigger for old package publish jobs * all 'test all' job and turn off trigger for old job * fix duplicated dependencies * add publish dry runs * add promotion dry run jobs * [Yamato][Packages] Use unique package artifact paths (#1557) * cherrypick: packages path fix (#1045) (missing backport from release branches to master) * try copy * change path * mkdir * copy artifacts together * remove quotes * use %%x as in batch file * add temp publish_shadergraph --dry-run to test publishing with new paths * mac cmd * fix macos mkdir * add artifacts-path to publish and promote, add shadergraph dryrun publish/promote * add copy to publish * mkdir publish * add missing copycmd * test dependencies cmd * remove artifacts path from promote * add promote copy .json back * use constant for temp path, update templates pack path * undo artifact path *.tgz endings * [Yamato] add missing commands to core package test (#1561) * add missing commands to core * let abv use project context
ellioman
added
backported-7.x
backported-8.x
backported-9.x
and removed
needs-backport-7.x
needs-backport-8.x
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Store all pack artifacts under unique paths, so that we can test several packages at once without being dependent on artifact order (and overwriting of artifacts)
Testing status
Yamato: (Select your branch):
https://yamato.prd.cds.internal.unity3d.com/jobs/902-Graphics/tree/yamato%252Fpackage-cmds
Shadergraph promote dry-run: https://yamato.prd.cds.internal.unity3d.com/jobs/902-Graphics/tree/yamato%252Fpackage-cmds/.yamato%252F_preview_publish.yml%2523promote_shadergraph_dry/3067575/job