Skip to content

Bugfix for HDRenderPipelineAsset getting set to null when running uni… #1696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 31, 2020
Merged

Bugfix for HDRenderPipelineAsset getting set to null when running uni… #1696

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions com.unity.render-pipelines.high-definition/Editor/Lighting/Reflection/HDCubemapInspector.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,13 @@ static void InitIcons()
}
public override Texture2D RenderStaticPreview(string assetPath, Object[] subAssets, int width, int height)
{
// If we attempted to render hdr cubemap previews in batchmode,
// we will error out with Texture creation failed. 'R16G16B16A16_SFloat' is not supported for Render usage on this platform.
// This would then trigger us to eject out of this function, without restoring the render pipeline asset.
// This causes GraphicsSettings to lose the reference to the HDRenderPipelineAsset, which causes all sorts of graphics build issues.
if (Application.isBatchMode)
return null;

m_CameraDistance = 1.25f;
m_CameraPhi = Mathf.PI * 0.33f;
m_CameraTheta = Mathf.PI;
Expand Down