Skip to content

Conversation

theopnv
Copy link
Contributor

@theopnv theopnv commented Sep 14, 2020

Purpose of this PR

Temporarily deactivate the standalone smoke tests. #1680 will fix them but it requires to pin a newer version of the editor than the current one. Doing so will make the vfx tests fail.
A fix for the vfx tests is supposed to land this week, so once it fixes the vfx tests with a newest editor version, we'll have to:

  1. Pin the new version
  2. Revert this PR
  3. Merge Split build & Execution for standalone tests (smoke, linux) [skip ci] #1680 into master

Once this is done, the smoke tests and the vfx tests will both work.
In the meantime we choose to keep the vfx tests and to deactivate the smoke tests (standalone only)

Automated tests

In the nightly, https://yamato.prd.cds.internal.unity3d.com/jobs/902-Graphics/tree/yamato%252Ftmp-deactivate-smoke-tests/.yamato%252F_abv.yml%2523all_project_ci_nightly_trunk/3454290/job/pipeline, standalone smoke tests are disabled.

@theopnv theopnv requested a review from a team as a code owner September 14, 2020 08:35
@github-actions
Copy link

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page)
and cancel any jobs that started on Yamato.
See the PR template for more information.
Thank you!

@sophiaaar sophiaaar merged commit 7c377d8 into master Sep 15, 2020
@sophiaaar sophiaaar deleted the yamato/tmp-deactivate-smoke-tests branch September 15, 2020 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants