Missed renaming of existing inline Vector1 for rename Vector1 to Float #2159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It appears that you made a non-draft PR! |
cdxntchou
approved these changes
Oct 9, 2020
ghost
approved these changes
Oct 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Complement to PR - #1979
Missed renaming existing inline Vector1 node.
Rename also the Vector1 in the popup of custom function
Testing status
I loaded shader graph project and checked that all Vector1 inline node were correctly converted to Float node
I have created a custom function and tested it works correctly, also checked the generated code to be sure everything is fine (i.e still use Vector1 internally)
Tested sugraph output:
Comments to reviewers
Notes for the reviewers you have assigned.