Skip to content

Conversation

kivistikliis
Copy link
Contributor

@kivistikliis kivistikliis commented Oct 12, 2020


Purpose of this PR

Because master uses editor pinning but the release branches dont, the yamato script is different between master and the rest, which complicates backporting yamato PRs. With #2112 landing on master, we can keep the script matching between the branches.

This PR takes the latest yamato changes (such that ymls stay content-wise unchanged for 8xx) in order to have the scripts between branches in sync.

Changes coming with this PR:

  • reruncount=2 flag
  • smoke tests in their own project metafiles
  • optional editor pinning
  • linux split build
  • editmode disabled for Metal
  • project logs included in artifacts

Testing status

ABV https://yamato.cds.internal.unity3d.com/jobs/902-Graphics/tree/8.x.x%252Fyamato%252Fupdate-ruamel/.yamato%252F_abv.yml%2523all_project_ci_fast-2020.1/3778361/job


Comments to reviewers

Notes for the reviewers you have assigned.

@kivistikliis kivistikliis changed the title [skip ci] Take latest ruamel script from master [skip ci] *xx Take latest ruamel script from master Oct 12, 2020
@kivistikliis kivistikliis changed the title [skip ci] *xx Take latest ruamel script from master [skip ci] 8xx Take latest ruamel script from master Oct 12, 2020
@kivistikliis kivistikliis marked this pull request as ready for review October 12, 2020 15:01
@kivistikliis kivistikliis requested a review from a team as a code owner October 12, 2020 15:01
@kivistikliis kivistikliis changed the title [skip ci] 8xx Take latest ruamel script from master 8xx Take latest ruamel script from master Oct 12, 2020
@theopnv
Copy link
Contributor

theopnv commented Oct 12, 2020

Can you add the backport for this one too please @kivistikliis ? #1980
It's only for 8.x.x, no need for backporting on 7.x.x as the line doesn't exist there

@kivistikliis
Copy link
Contributor Author

good one, backported #1980 now!

@theopnv theopnv merged commit 38e9438 into 8.x.x/release Oct 21, 2020
@theopnv theopnv deleted the 8.x.x/yamato/update-ruamel branch October 21, 2020 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants