[HOLD] Specular color on HDRP/Lit below 2% can be used to suppress specular lighting completely #2556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasKiniulis
approved these changes
Nov 6, 2020
|
I am seeing several yamato failures, will investigate shortly. |
sebastienlagarde
approved these changes
Nov 6, 2020
# Conflicts: # TestProjects/HDRP_DXR_Tests/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D12/None/900_Materials_AlphaTest_SG.png # TestProjects/HDRP_Tests/Assets/ReferenceImages/Linear/LinuxEditor/Vulkan/None/2205_LightLoopCullWOblique.png # TestProjects/HDRP_Tests/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D11/None/2205_LightLoopCullWOblique.png # TestProjects/HDRP_Tests/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D12/None/2205_LightLoopCullWOblique.png # TestProjects/HDRP_Tests/Assets/ReferenceImages/Linear/WindowsEditor/Vulkan/None/2205_LightLoopCullWOblique.png # com.unity.render-pipelines.high-definition/CHANGELOG.md
FrancescoC-unity
changed the title
|
Hi, we need this, and currently it seems the only way to suppress specular is to disable affect specular from the directional light. |
|
Hi, the transmission/sss shaders don't have a specular color. Will this feature be available for those shader types? We really need this for foliage shaders. Could this be added to the smoothness instead? 0 smoothness = 0 spec highlight. Thanks! |
|
Guys, when already?((( |
|
recreated in private repo |
Where is it? |
|
Hi yes we need this Where is it ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The specular color can now be used to completely kill specular. Values from 2% to 0% slowly kill fresnel killing the remaining specular that would be there otherwise.
Before with black specular color
Now with black specular color
Here is a gif to show transition
What did I test:
Can be seen in the gif :)
Yamato: (Just kicked) https://yamato.cds.internal.unity3d.com/jobs/902-Graphics/tree/HDRP%252Fkill-specular/.yamato%252Fall-hdrp.yml%2523All_HDRP_trunk/4112834/job