Skip to content

Move EndCameraRendering callback out of the profiling scope #2917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 17, 2020
Merged

Move EndCameraRendering callback out of the profiling scope #2917

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a123bd7
Move EndCameraRendering callback out of the profiling scope
adrien-de-tocqueville Dec 16, 2020
a21d620
added a comment
adrien-de-tocqueville Dec 16, 2020
d12b05d
Merge branch 'hd/bugfix' into hd/end-rendering-fix
sebastienlagarde Dec 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.render-pipelines.high-definition/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fixed a small discrepancy in the marker placement in light intensity sliders (case 1299750)
- Fixed issue with VT resolve pass rendergraph errors when opaque and transparent are disabled in frame settings.
- Fixed a bug in the sphere-aabb light cluster (case 1294767).
- Fixed issue when submitting SRPContext during EndCameraRendering.

### Changed
- Removed the material pass probe volumes evaluation mode.
Expand Down
4 changes: 3 additions & 1 deletion com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/HDRenderPipeline.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1902,9 +1902,11 @@ ref _cullingResults
cmd.SetInvertCulling(renderRequest.cameraSettings.invertFaceCulling);
ExecuteRenderRequest(renderRequest, renderContext, cmd, AOVRequestData.defaultAOVRequestDataNonAlloc);
cmd.SetInvertCulling(false);
UnityEngine.Rendering.RenderPipeline.EndCameraRendering(renderContext, renderRequest.hdCamera.camera);
}

// EndCameraRendering callback should be executed outside of any profiling scope in case user code submits the renderContext
EndCameraRendering(renderContext, renderRequest.hdCamera.camera);

{
var target = renderRequest.target;
// Handle the copy if requested
Expand Down