Draw the VCS toolbar when Perforce is activated in the Volume Editor #295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredericv-unity3d
changed the title
fredericv-unity3d
force-pushed
the
HDRP/fix_perforce_volume
branch
from
928bcf3 to
f479593
Compare
fredericv-unity3d
changed the title
PaulDemeulenaere
pushed a commit
that referenced
this pull request
Nov 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Fix case 1136601.
Issue: when using Perforce, there is no way to checkout a profile for edition from the Volume Inspector.
I drawed the VCS toolbar used for the asset inside the editor, so we have a fast access to the VCS features of the volume profile.
TODO:
Previous UI:
New UI:
Rationale
Testing status
Manual Tests:
Comments to reviewers