Skip to content

[HDRP] Enable GetSamplePosition on metal #2988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 8, 2021
Merged

[HDRP] Enable GetSamplePosition on metal #2988

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions ...der-pipelines.high-definition/Runtime/Lighting/LightLoop/lightlistbuild-clustered.compute
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,11 +233,7 @@ void LIGHTLISTGEN(uint threadID : SV_GroupIndex, uint3 u3GroupID : SV_GroupID)
for(int i=0; i<g_iNumSamplesMSAA; i++)
{
const float fDpth = FetchDepthMSAA(uPixCrd, i);
#if defined(SHADER_API_METAL) // GetSamplePosition isn't supported on Metal yet in Unity. TODO: remove when support is added
const float2 fracSampleCoord = float2(0.0, 0.0);
#else
const float2 fracSampleCoord = g_depth_tex.GetSamplePosition(i).xy; // this is optimized away when USE_OBLIQUE_MODE is NOT set.
#endif
#else
const float fDpth = FetchDepth(uPixCrd);
const float2 fracSampleCoord = float2(0.5,0.5);
Expand Down