Change the source value for the ray tracing frame index iterator from m_FrameCount to the camera frame count (case 1301356). #3032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… m_FrameCount to the camera frame count (case 1301356).
remi-chapelain
approved these changes
Jan 8, 2021
sebastienlagarde
approved these changes
Jan 14, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to recent changes, the m_FrameCount is updated once for every rendered camera image. This changes the source iterator from m_Frame count to camera frame count for correct scene view results and solves the issue in the fogbugz
https://fogbugz.unity3d.com/f/cases/1301356/
Testing status
We do not see the artifacts anymore on the test
DXR tests are green locally