Skip to content

Conversation

hdb-unity
Copy link
Contributor

@hdb-unity hdb-unity commented Feb 10, 2021

Purpose of this PR

This PR copies scenes from UniveralGraphicsTest into UniversalGraphicsTest_2D, UniversalGraphicsTest_Foundation, UniversalGraphicsTest_Lighting, UniversalGraphicsTest_Terrain, UniversalGraphicsTest_PostPro.

The aims are to enable better collaboration by separating test projects by team, or at least by concern. Also, to reduce iteration time and CI resource load by allowing developers to more easily run tests relating to the areas of their code changes; instead of running the entire suite each run locally or in CI. The entire suite can and should then be run after iteration to give the full coverage.

This PR lands split projects into master branch.


Testing status

Manual Tests: What did you do?

  • Run split projects in CI
  • Run original project in CI
  • Run split projects locally on MacOS
  • Tested backport process from these split projects to universal/split-project-20.1 and universal/split-project-19.3
  • Reverted changes commit to UniversalGraphicsTest project (it should NOT be changed by this PR)

Comments to reviewers

  • CI jobs should continue to use UniversalGraphicsTest after this PR
  • This PR should not change any code outside of TestProjects
  • This PR should not change any projects in TestProjects, except UniversalGraphicsTest_2D, UniversalGraphicsTest_Foundation, UniversalGraphicsTest_Lighting, UniversalGraphicsTest_Terrain, UniversalGraphicsTest_PostPro
  • There are tasks to complete after this PR (as discussed with reviewers)

Bhik95 and others added 30 commits March 25, 2020 19:07
# Conflicts:
#	TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/Android/OpenGLES3/None/015_CameraMulti_FPSCam.png.meta
#	TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/Android/OpenGLES3/None/077_GradingChannelMixerLDR.png.meta
#	TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/Android/OpenGLES3/None/079_GradingColorAdjustmentsLDR.png.meta
#	TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/Android/OpenGLES3/None/081_GradingColorCurvesLDR.png.meta
#	TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/Android/OpenGLES3/None/083_GradingLiftGammaGainLDR.png.meta
#	TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/Android/OpenGLES3/None/085_GradingShadowsMidtonesHighlightsLDR.png.meta
#	TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/Android/OpenGLES3/None/087_GradingSplitToningLDR.png.meta
#	TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/Android/OpenGLES3/None/089_GradingWhiteBalanceLDR.png.meta
#	TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/Android/OpenGLES3/None/091_TonemappingNeutralLDR.png.meta
#	TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/Android/OpenGLES3/None/108_MoveCamera.png.meta
#	TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/Android/OpenGLES3/None/109_URPShadersAlphaOutput.png.meta
#	TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/Android/OpenGLES3/None/119_CameraToRTWithViewportRect.png.meta
#	TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/Android/OpenGLES3/None/120_RenderUICustomRendererNoPP.png.meta
#	TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/Android/OpenGLES3/None/121_RenderUICustomRendererNoAA.png.meta
#	TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/Android/OpenGLES3/None/122_RenderUICustomRendererFXAA.png.meta
#	TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/Android/OpenGLES3/None/125_CameraStackingVolumes.png.meta
#	TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/Android/OpenGLES3/None/126_RendererFeatureActive.png.meta
#	TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/Android/Vulkan/None/015_CameraMulti_FPSCam.png.meta
#	TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/Android/Vulkan/None/041_Lighting_BasicArea.png.meta
#	TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/Android/Vulkan/None/077_GradingChannelMixerLDR.png.meta
#	TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/Android/Vulkan/None/079_GradingColorAdjustmentsLDR.png.meta
#	TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/Android/Vulkan/None/081_GradingColorCurvesLDR.png.meta
#	TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/Android/Vulkan/None/083_GradingLiftGammaGainLDR.png.meta
#	TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/Android/Vulkan/None/085_GradingShadowsMidtonesHighlightsLDR.png.meta
#	TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/Android/Vulkan/None/087_GradingSplitToningLDR.png.meta
#	TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/Android/Vulkan/None/089_GradingWhiteBalanceLDR.png.meta
#	TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/Android/Vulkan/None/091_TonemappingNeutralLDR.png.meta
#	TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/Android/Vulkan/None/108_MoveCamera.png.meta
#	TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/Android/Vulkan/None/109_URPShadersAlphaOutput.png.meta
#	TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/Android/Vulkan/None/119_CameraToRTWithViewportRect.png.meta
#	TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/Android/Vulkan/None/120_RenderUICustomRendererNoPP.png.meta
#	TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/Android/Vulkan/None/121_RenderUICustomRendererNoAA.png.meta
#	TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/Android/Vulkan/None/122_RenderUICustomRendererFXAA.png.meta
#	TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/Android/Vulkan/None/125_CameraStackingVolumes.png.meta
#	TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/Android/Vulkan/None/126_RendererFeatureActive.png.meta
#	TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/WindowsPlayer/Direct3D11/None/041_Lighting_BasicArea.png.meta
#	TestProjects/UniversalGraphicsTest/Assets/Scenes/041_Lighting_BasicAreaSettings.lighting
#	TestProjects/UniversalGraphicsTest/Assets/Scenes/041_Lighting_BasicAreaSettings.lighting.meta
#	TestProjects/UniversalGraphicsTest/Assets/Scenes/045_CustomLWPipe.unity
#	TestProjects/UniversalGraphicsTest/Packages/manifest.json
#	TestProjects/UniversalGraphicsTest/UserSettings/EditorUserSettings.asset
…is done in UniversalGraphicsTest project"

This reverts commit 718d146.
hdb-unity and others added 10 commits December 28, 2020 18:39
… split project contents to latest. NOTE: only adds updated files with this commit. All new files added by replacing manual-split projects with auto-split projects will be added separately.
… split project contents to latest. NOTE: only adds new files with this commit. All updated files modified by replacing manual-split projects with auto-split projects have been added in a prior commit.
@hdb-unity hdb-unity changed the base branch from universal/split-project-20.2 to master February 11, 2021 12:30
project:
name: Universal_Split
expression_trigger:
expression: ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be simpler to have the expression trigger expression: 'pull_request.target eq "<TARGET_BRANCH>" AND NOT pull_request.draft AND pull_request.changes.any match ["com.unity.render-pipelines.universal/**/*", "TestProjects/UniversalGraphicsTest/**/*"] AND NOT pull_request.push.changes.all match ["*.md", "**/*.md", "doc/**/*", "**/Documentation*/**/*"]' here instead of duplicated in the 5 projects?

@stramit stramit marked this pull request as ready for review February 11, 2021 16:27
@stramit stramit requested a review from a team as a code owner February 11, 2021 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants