-
Notifications
You must be signed in to change notification settings - Fork 855
Universal/split project 20.2 autosplit #3448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… and added 071_Terrain_Holes
# Conflicts: # TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/Android/OpenGLES3/None/015_CameraMulti_FPSCam.png.meta # TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/Android/OpenGLES3/None/077_GradingChannelMixerLDR.png.meta # TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/Android/OpenGLES3/None/079_GradingColorAdjustmentsLDR.png.meta # TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/Android/OpenGLES3/None/081_GradingColorCurvesLDR.png.meta # TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/Android/OpenGLES3/None/083_GradingLiftGammaGainLDR.png.meta # TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/Android/OpenGLES3/None/085_GradingShadowsMidtonesHighlightsLDR.png.meta # TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/Android/OpenGLES3/None/087_GradingSplitToningLDR.png.meta # TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/Android/OpenGLES3/None/089_GradingWhiteBalanceLDR.png.meta # TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/Android/OpenGLES3/None/091_TonemappingNeutralLDR.png.meta # TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/Android/OpenGLES3/None/108_MoveCamera.png.meta # TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/Android/OpenGLES3/None/109_URPShadersAlphaOutput.png.meta # TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/Android/OpenGLES3/None/119_CameraToRTWithViewportRect.png.meta # TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/Android/OpenGLES3/None/120_RenderUICustomRendererNoPP.png.meta # TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/Android/OpenGLES3/None/121_RenderUICustomRendererNoAA.png.meta # TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/Android/OpenGLES3/None/122_RenderUICustomRendererFXAA.png.meta # TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/Android/OpenGLES3/None/125_CameraStackingVolumes.png.meta # TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/Android/OpenGLES3/None/126_RendererFeatureActive.png.meta # TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/Android/Vulkan/None/015_CameraMulti_FPSCam.png.meta # TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/Android/Vulkan/None/041_Lighting_BasicArea.png.meta # TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/Android/Vulkan/None/077_GradingChannelMixerLDR.png.meta # TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/Android/Vulkan/None/079_GradingColorAdjustmentsLDR.png.meta # TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/Android/Vulkan/None/081_GradingColorCurvesLDR.png.meta # TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/Android/Vulkan/None/083_GradingLiftGammaGainLDR.png.meta # TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/Android/Vulkan/None/085_GradingShadowsMidtonesHighlightsLDR.png.meta # TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/Android/Vulkan/None/087_GradingSplitToningLDR.png.meta # TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/Android/Vulkan/None/089_GradingWhiteBalanceLDR.png.meta # TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/Android/Vulkan/None/091_TonemappingNeutralLDR.png.meta # TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/Android/Vulkan/None/108_MoveCamera.png.meta # TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/Android/Vulkan/None/109_URPShadersAlphaOutput.png.meta # TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/Android/Vulkan/None/119_CameraToRTWithViewportRect.png.meta # TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/Android/Vulkan/None/120_RenderUICustomRendererNoPP.png.meta # TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/Android/Vulkan/None/121_RenderUICustomRendererNoAA.png.meta # TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/Android/Vulkan/None/122_RenderUICustomRendererFXAA.png.meta # TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/Android/Vulkan/None/125_CameraStackingVolumes.png.meta # TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/Android/Vulkan/None/126_RendererFeatureActive.png.meta # TestProjects/UniversalGraphicsTest/Assets/ReferenceImages/Linear/WindowsPlayer/Direct3D11/None/041_Lighting_BasicArea.png.meta # TestProjects/UniversalGraphicsTest/Assets/Scenes/041_Lighting_BasicAreaSettings.lighting # TestProjects/UniversalGraphicsTest/Assets/Scenes/041_Lighting_BasicAreaSettings.lighting.meta # TestProjects/UniversalGraphicsTest/Assets/Scenes/045_CustomLWPipe.unity # TestProjects/UniversalGraphicsTest/Packages/manifest.json # TestProjects/UniversalGraphicsTest/UserSettings/EditorUserSettings.asset
…in UniversalGraphicsTest project
…sh bug in 2020.2.0a17" This reverts commit 3051415.
…is done in UniversalGraphicsTest project" This reverts commit 718d146.
This reverts commit c6c7197.
…to pass in ..._Terrain
…it' - excluding .yamato changes
… split project contents to latest. NOTE: only adds updated files with this commit. All new files added by replacing manual-split projects with auto-split projects will be added separately.
… split project contents to latest. NOTE: only adds new files with this commit. All updated files modified by replacing manual-split projects with auto-split projects have been added in a prior commit.
project: | ||
name: Universal_Split | ||
expression_trigger: | ||
expression: "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't it be simpler to have the expression trigger expression: 'pull_request.target eq "<TARGET_BRANCH>" AND NOT pull_request.draft AND pull_request.changes.any match ["com.unity.render-pipelines.universal/**/*", "TestProjects/UniversalGraphicsTest/**/*"] AND NOT pull_request.push.changes.all match ["*.md", "**/*.md", "doc/**/*", "**/Documentation*/**/*"]'
here instead of duplicated in the 5 projects?
Purpose of this PR
This PR copies scenes from UniveralGraphicsTest into UniversalGraphicsTest_2D, UniversalGraphicsTest_Foundation, UniversalGraphicsTest_Lighting, UniversalGraphicsTest_Terrain, UniversalGraphicsTest_PostPro.
The aims are to enable better collaboration by separating test projects by team, or at least by concern. Also, to reduce iteration time and CI resource load by allowing developers to more easily run tests relating to the areas of their code changes; instead of running the entire suite each run locally or in CI. The entire suite can and should then be run after iteration to give the full coverage.
This PR lands split projects into master branch.
Testing status
Manual Tests: What did you do?
Comments to reviewers