Copy test scene 146_AdditionalLightShadowCustomResolution to test project UniversalGraphicsTest_Lighting #3558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stomResolution to UniversalGraphicsTest_Lighting/.../146_AdditionalLightShadowCustomResolution
|
It appears that you made a non-draft PR! |
|
Is that test scene testing real time lighting only? If so it should be in _Foundation instead. |
Yes it only tests real-time lighting (so does 145_ManyAdditionalLightShadowTypes that is also in split-project "Lighting" currently). |
hdb-unity
approved these changes
Feb 23, 2021
Wilfrid-Unity
deleted the
universal/split-test-projects/146-shadow-resolution
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
#2126 added automated test scene https://github.com/Unity-Technologies/Graphics/blob/master/TestProjects/UniversalGraphicsTest/Assets/Scenes/146-AdditionalLightShadowCustomResolution.unity
#3448 copied project UniversalGraphicsTest scenes to 5 smaller test projects. However test scene 146-AdditionalLightShadowCustomResolution.unity was not included during this copy.
I think this might be caused by the hyphen in the scene name, that might have confused the tooling.
This pull request copies test scene 146-AdditionalLightShadowCustomResolution.unity from test project UniversalGraphicsTest to test project UniversalGraphicsTest_Lighting (and renames it to use an underscore instead of the hyphen).