Skip to content

Fix for shader variant max exceeded error #3664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 1, 2021
Merged

Fix for shader variant max exceeded error #3664

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
743c942
fixing error message that used to attach to the master node to print …
elizabeth-legros Feb 26, 2021
4b533f0
Update CHANGELOG.md
elizabeth-legros Feb 26, 2021
b48900b
formatting
elizabeth-legros Mar 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.shadergraph/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fixed virtual texture layer reference names allowing invalid characters [1304146]
- Fixed issue with SRP Batcher compatibility [1310624]
- Fixed issue with Hybrid renderer compatibility [1296776]
- Fixed an issue where the shader variant limit exceeded message was not getting passed [1304168] (https://issuetracker.unity3d.com/product/unity/issues/guid/1304168)


## [11.0.0] - 2020-10-21
Expand Down
5 changes: 5 additions & 0 deletions com.unity.shadergraph/Editor/Data/Implementation/GraphObject.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,11 @@ class GraphObject : ScriptableObject, ISerializationCallbackReceiver
[SerializeField]
string m_AssetGuid;

internal string AssetGuid
{
get => m_AssetGuid;
}

[NonSerialized]
GraphData m_Graph;

Expand Down
11 changes: 10 additions & 1 deletion com.unity.shadergraph/Editor/Generation/Processors/Generator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,16 @@ void BuildShader()

if (m_GraphData.GetKeywordPermutationCount() > ShaderGraphPreferences.variantLimit)
{
m_GraphData.AddValidationError(m_OutputNode.objectId, ShaderKeyword.kVariantLimitWarning, Rendering.ShaderCompilerMessageSeverity.Error);
string graphName = "";
if (m_GraphData.owner != null)
{
string path = AssetDatabase.GUIDToAssetPath(m_GraphData.owner.AssetGuid);
if (path != null)
{
graphName = Path.GetFileNameWithoutExtension(path);
}
}
Debug.LogError($"Error in Shader Graph {graphName}:{ShaderKeyword.kVariantLimitWarning}");

m_ConfiguredTextures = shaderProperties.GetConfiguredTextures();
m_Builder.AppendLines(ShaderGraphImporter.k_ErrorShader);
Expand Down