Temporarily disabled warnings in Core shader library for gles platforms. #3931
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JulienIgnace-Unity
requested review from
ellioman,
sebastienlagarde and
stramit
phi-lira
approved these changes
Mar 19, 2021
sebastienlagarde
approved these changes
Mar 19, 2021
stramit
approved these changes
Mar 23, 2021
sebastienlagarde
pushed a commit
that referenced
this pull request
Apr 2, 2021
…ms. (#3931) * Temporarily disabled warnings in Core shader library for gles platforms. * Move the pragma warning to all the specific files instead of globally
sebastienlagarde
added a commit
that referenced
this pull request
Apr 2, 2021
* Temporarily disabled warnings in Core shader library for gles platforms. (#3931) * Temporarily disabled warnings in Core shader library for gles platforms. * Move the pragma warning to all the specific files instead of globally * Added mobile preprocessor guards around half conversion warning pragmas (#4009) * Added missing implicit conversion from TextureHandle to Texture (#4013) * Moved path tracing limitations to the path tracing documentation and added information about streaming virtual texturing. (#4014) * Fix spot light near plane gizmo (#4026) * Added information clarifying what ambient occlusion is available in AOVs (#4042) Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> Co-authored-by: Robert Cupisz <robertcupisz@gmail.com>
sebastienlagarde
pushed a commit
that referenced
this pull request
Apr 15, 2021
…ms. (#3931) * Temporarily disabled warnings in Core shader library for gles platforms. * Move the pragma warning to all the specific files instead of globally
sebastienlagarde
pushed a commit
that referenced
this pull request
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
This PR temporarily disables warnings in Core shader library for gles platforms.
The proper fixes will be done later as we start using those functions for real on gles platforms.
https://fogbugz.unity3d.com/f/cases/1316887/
Testing status
Tested the repro steps from the linked case.