Skip to content

Various SRP and HDRP backport #4069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 2, 2021
Merged

Various SRP and HDRP backport #4069

merged 6 commits into from
Apr 2, 2021

Conversation

sebastienlagarde
Copy link
Contributor

@sebastienlagarde sebastienlagarde commented Apr 2, 2021 •
edited
Loading

Purpose of this PR

  • Temporarily disabled warnings in Core shader library for gles platfor…
  • Added mobile preprocessor guards around half conversion warning pragm…
  • Added missing implicit conversion from TextureHandle to Texture (Fixed error when disabling opaques #4013)
  • Moved path tracing limitations to the path tracing documentation and …
  • Fix spot light near plane gizmo (Fix spot light near plane gizmo #4026)
  • Added information clarifying what ambient occlusion is available in A… …

Testing status

Describe what manual/automated tests were performed for this PR

Comments to reviewers

Notes for the reviewers you have assigned.

@sebastienlagarde sebastienlagarde requested a review from a team as a code owner April 2, 2021 09:48
@sebastienlagarde sebastienlagarde changed the base branch from master to 2021.1/staging April 2, 2021 09:49
@sebastienlagarde sebastienlagarde requested review from JulienIgnace-Unity and removed request for a team April 2, 2021 09:49
@github-actions
Copy link

github-actions bot commented Apr 2, 2021

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page)
and cancel any jobs that started on Yamato.
See the PR template for more information.
Thank you!

@sebastienlagarde sebastienlagarde merged commit 340190e into 2021.1/staging Apr 2, 2021
@sebastienlagarde sebastienlagarde deleted the HDRP/Backport-20211 branch April 2, 2021 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JulienIgnace-Unity JulienIgnace-Unity Awaiting requested review from JulienIgnace-Unity

Assignees

No one assigned

Labels

HDRP SRP

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sebastienlagarde @JulienIgnace-Unity @JordanL8 @robcupisz