Reduce clear calls in TextureCache ClearCache functions #3999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It appears that you made a non-draft PR! |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
FrancescoC-unity
approved these changes
Mar 25, 2021
There was a problem hiding this comment.
Discussed with @christine-johnson and the tests she did sounded good to me. (Checked via renderdoc that clears do happen)
Let's see how yamato goes.
sebastienlagarde
pushed a commit
that referenced
this pull request
Mar 31, 2021
sebastienlagarde
added a commit
that referenced
this pull request
Mar 31, 2021
* [HDRP] Merge Hd/bugfix #3920 * fix various issue * Update 1302_StackLitSG_PixarLM.unity * Added information about requiring directional lights (#3899) * Increased resolution of light cheat sheet (#3903) * Update 1302_StackLitSG_PixarLM.png * Dirtying an asset that was upgraded to a new Version #3964 * Reduce clear calls in TextureCache ClearCache functions #3999 * [HDRP] Merge Hd/bugfix #4005 * Moved path tracing limitations to the path tracing documentation and added information about streaming virtual texturing. (#4014) * Added information clarifying what ambient occlusion is available in AOVs (#4042) * Fix spot light near plane gizmo (#4026) * Update DebugDisplay.cs Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> Co-authored-by: Jennifer Roig-Deslandes <71718938+jenniferd-unity@users.noreply.github.com> Co-authored-by: christine-johnson <60632921+christine-johnson@users.noreply.github.com> Co-authored-by: Robert Cupisz <robertcupisz@gmail.com>
sebastienlagarde
added a commit
that referenced
this pull request
Mar 31, 2021
This reverts commit f6a95c0.
sebastienlagarde
pushed a commit
that referenced
this pull request
Apr 1, 2021
sebastienlagarde
added a commit
that referenced
this pull request
Apr 2, 2021
* Fixing planar reflection probes issues [FogBugz 1312153] #3627 * Update PostProcessSystem.cs * Update PostProcessSystem.RenderGraph.cs * Update HDCamera.cs * Update PostProcessSystem.cs * Update HDCamera.cs * Update HDRenderPipeline.cs * Update HDRenderPipeline.cs * Update 002-HDMaterials.png * update reference screenshots * Added information about requiring directional lights (#3899) * Increased resolution of light cheat sheet (#3903) * [HDRP] Merge Hd/bugfix #3920 * Update 1302_StackLitSG_PixarLM.unity * Update 1302_StackLitSG_PixarLM.png * Dirtying an asset that was upgraded to a new Version #3964 * [HDRP] bugfixes scene selection pass in SG, StackLit debug specular color mod #3985 * Reduce clear calls in TextureCache ClearCache functions (#3999) * [HDRP] Merge Hd/bugfix #4005 * [HDRP] Merge Hd/bugfix #4005 * Formatting Co-authored-by: Kleber Garcia <kleber.garcia@unity3d.com> Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> Co-authored-by: Jennifer Roig-Deslandes <71718938+jenniferd-unity@users.noreply.github.com> Co-authored-by: slunity <37302815+slunity@users.noreply.github.com> Co-authored-by: christine-johnson <60632921+christine-johnson@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Reduces clear calls in TextureCache ClearCache functions by clearing texture arrays in a single call rather than clearing each slice separately.