Skip to content

Reduce clear calls in TextureCache ClearCache functions #3999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2021
Merged

Reduce clear calls in TextureCache ClearCache functions #3999

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions com.unity.render-pipelines.high-definition/Runtime/Core/Textures/TextureCache2D.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,13 +108,10 @@ internal void ClearCache()
var desc = m_Cache.descriptor;
bool isMipped = desc.useMipMap;
int mipCount = isMipped ? GetNumMips(desc.width, desc.height) : 1;
for (int depthSlice = 0; depthSlice < desc.volumeDepth; ++depthSlice)
for (int mipIdx = 0; mipIdx < mipCount; ++mipIdx)
{
for (int mipIdx = 0; mipIdx < mipCount; ++mipIdx)
{
Graphics.SetRenderTarget(m_Cache, mipIdx, CubemapFace.Unknown, depthSlice);
GL.Clear(false, true, Color.clear);
}
Graphics.SetRenderTarget(m_Cache, mipIdx, CubemapFace.Unknown, -1);
GL.Clear(false, true, Color.clear);
}
}

Expand Down
12 changes: 3 additions & 9 deletions com.unity.render-pipelines.high-definition/Runtime/Core/Textures/TextureCacheCubemap.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,16 +162,10 @@ internal void ClearCache()
var desc = m_Cache.descriptor;
bool isMipped = desc.useMipMap;
int mipCount = isMipped ? GetNumMips(desc.width, desc.height) : 1;
for (int depthSlice = 0; depthSlice < desc.volumeDepth; ++depthSlice)
for (int mipIdx = 0; mipIdx < mipCount; ++mipIdx)
{
for (int mipIdx = 0; mipIdx < mipCount; ++mipIdx)
{
for (int faceIdx = 0; faceIdx < 6; ++faceIdx)
{
Graphics.SetRenderTarget(m_Cache, mipIdx, (CubemapFace)faceIdx, depthSlice);
GL.Clear(false, true, Color.clear);
}
}
Graphics.SetRenderTarget(m_Cache, mipIdx, CubemapFace.Unknown, -1);
GL.Clear(false, true, Color.clear);
}
}

Expand Down