Skip to content

Conversation

TomasKiniulis
Copy link
Contributor

@TomasKiniulis TomasKiniulis commented Apr 23, 2021

PR is meant to bring coverage for the issue previously breaking Panini Projection with Color and Post Process buffer using Alpha channel that was fixed here: #4133, while also adding coverage for other effects performing their own pass to Color Buffer.

Test scene adds:

  • Panini+Bloom test
  • Motion Blur test

Test scene moves the following scenes to one:

  • TAA-FP16Alpha.unity
  • FXAA-FP16Alpha.unity
  • DepthOfField-FP16Alpha.unity

4101_FP16Alpha

Testing Status

  • Made sure Post Process test scenes are passing locally on Dx11
  • Made sure test scene is passing on Dx11, Dx12, Vulkan

Yamato Status

Copy link
Contributor

@JMargevics JMargevics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ✅

@sebastienlagarde sebastienlagarde marked this pull request as ready for review April 26, 2021 08:49
sebastienlagarde pushed a commit that referenced this pull request Apr 30, 2021
sebastienlagarde added a commit that referenced this pull request May 1, 2021
* [HDRP] Fp16_PPAlpha Panini projection, Motion Blur test and moved other Fp16Alpha scenes to one #4290

* Hd/redo fix inputregistering domainreload (#4358)

* Update InputRegistering.cs

* Remove asset modification if InputSystem package is in use

* Prevent missuse of InputRegistering while InputSystem package is in use

* cleaning

* more cleaning

* Update code to use Next instead of GetArrayElementAtIndex

* Fix strange out of range error

Co-authored-by: TomasKiniulis <50582134+TomasKiniulis@users.noreply.github.com>
Co-authored-by: Remi Slysz <40034005+RSlysz@users.noreply.github.com>
sebastienlagarde added a commit that referenced this pull request May 1, 2021
* [10.x.x HDRP] Fix issue with raytracing resources not properly initialize (#4268)

* draft

* Fix build DXR

* Match behavior with the one in master

* Updated ray tracing settings and added it to the table of contents  (#4279)

* Updated ray tracing settings and added it to the toc

* Removed hyphens from rtss toc entry

* Fix shader warning when using Lanczos upsampling (#4280)

* Added DOTS_INSTANCING_ON variants to the "HDRP/Decal" shader #4284

* [HDRP] Fp16_PPAlpha Panini projection, Motion Blur test and moved other Fp16Alpha scenes to one #4290

* [HDRP] Fix undo of some properties on light editor #4293

* Opt-out of builtin auto baking of ambient/reflection probe. #4324

* Revert "Opt-out of builtin auto baking of ambient/reflection probe. #4324"

This reverts commit 719e835.

* Hd/redo fix inputregistering domainreload (#4358)

* Update InputRegistering.cs

* Remove asset modification if InputSystem package is in use

* Prevent missuse of InputRegistering while InputSystem package is in use

* cleaning

* more cleaning

* Update code to use Next instead of GetArrayElementAtIndex

* Fix strange out of range error

Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>
Co-authored-by: Pavlos Mavridis <pavlos.mavridis@unity3d.com>
Co-authored-by: Andrew Saraev <67020478+AndrewSaraevUnity@users.noreply.github.com>
Co-authored-by: TomasKiniulis <50582134+TomasKiniulis@users.noreply.github.com>
Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com>
Co-authored-by: JulienIgnace-Unity <julien@unity3d.com>
Co-authored-by: Remi Slysz <40034005+RSlysz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants