Opt-out of builtin auto baking of ambient/reflection probe. #4324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It appears that you made a non-draft PR! |
sebastienlagarde
approved these changes
Apr 27, 2021
|
I tried to take a look at this and compare Master vs Branch. Not sure what it is fixing, on master I get exactly the same result before and after the fix. It's likely I'm doing something wrong, so maybe you could share screenshots with before and after, I could use them to evaluate and approve Master PR |
|
Before After So what we fix here is that it's not blue. Basically it just shows us that we don't run useless systems meant for builtin renderer. |
iM0ve
approved these changes
Apr 27, 2021
… into hd/skymanager-optout # Conflicts: # com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/HDRenderPipeline.cs
sebastienlagarde
pushed a commit
that referenced
this pull request
Apr 30, 2021
sebastienlagarde
added a commit
that referenced
this pull request
May 1, 2021
* [10.x.x HDRP] Fix issue with raytracing resources not properly initialize (#4268) * draft * Fix build DXR * Match behavior with the one in master * Updated ray tracing settings and added it to the table of contents (#4279) * Updated ray tracing settings and added it to the toc * Removed hyphens from rtss toc entry * Fix shader warning when using Lanczos upsampling (#4280) * Added DOTS_INSTANCING_ON variants to the "HDRP/Decal" shader #4284 * [HDRP] Fp16_PPAlpha Panini projection, Motion Blur test and moved other Fp16Alpha scenes to one #4290 * [HDRP] Fix undo of some properties on light editor #4293 * Opt-out of builtin auto baking of ambient/reflection probe. #4324 * Revert "Opt-out of builtin auto baking of ambient/reflection probe. #4324" This reverts commit 719e835. * Hd/redo fix inputregistering domainreload (#4358) * Update InputRegistering.cs * Remove asset modification if InputSystem package is in use * Prevent missuse of InputRegistering while InputSystem package is in use * cleaning * more cleaning * Update code to use Next instead of GetArrayElementAtIndex * Fix strange out of range error Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> Co-authored-by: Pavlos Mavridis <pavlos.mavridis@unity3d.com> Co-authored-by: Andrew Saraev <67020478+AndrewSaraevUnity@users.noreply.github.com> Co-authored-by: TomasKiniulis <50582134+TomasKiniulis@users.noreply.github.com> Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com> Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> Co-authored-by: Remi Slysz <40034005+RSlysz@users.noreply.github.com>
sebastienlagarde
pushed a commit
that referenced
this pull request
May 27, 2021
sebastienlagarde
pushed a commit
that referenced
this pull request
Jun 14, 2021
sebastienlagarde
added a commit
that referenced
this pull request
Jun 16, 2021
* Opt-out of builtin auto baking of ambient/reflection probe. #4324 * Fix Unifed Shader Precision Model in SRP shaders by supporting half precision on desktop #4349 * Improved property descriptions (#4451) * Improved property descriptions Improved descriptions to address Remi's slack question: "How is calculated the distance at which diffusion profile stops having an effect in HDRP ? And what does it depends on ?" * Fixed scale 0.01 > 0.001 * [HDRP] Merge Hd/bugfix #4731 * Update CHANGELOG.md * [HDRP] Merge Hd/bugfix #4713 * fix compil issue * Update SubsurfaceScatteringManagerRT.cs * Update 902_Materials_SG_Variants_Lit.png Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> Co-authored-by: NetteVI <nette.vi@gmail.com> Co-authored-by: Vic Cooper <63712500+Vic-Cooper@users.noreply.github.com>
sebastienlagarde
added a commit
that referenced
this pull request
Jun 16, 2021
* Opt-out of builtin auto baking of ambient/reflection probe. #4324 * Fix Unifed Shader Precision Model in SRP shaders by supporting half precision on desktop #4349 * Improved property descriptions (#4451) * Improved property descriptions Improved descriptions to address Remi's slack question: "How is calculated the distance at which diffusion profile stops having an effect in HDRP ? And what does it depends on ?" * Fixed scale 0.01 > 0.001 * [HDRP] Merge Hd/bugfix #4731 * Update CHANGELOG.md * [HDRP] Merge Hd/bugfix #4713 * fix compil issue * Update SubsurfaceScatteringManagerRT.cs * Update 902_Materials_SG_Variants_Lit.png * Align LitTessellation to Lit and LayereLitTessellation to LayeredLit. + make the former fallback on the latter in R #4661 * Merge Hd/bugfix #4825 * Merge Hd/bugfix #4830 * fix Dx12 screenshots * Update CHANGELOG.md * Update CHANGELOG.md * add exception for the renaming of LightLayersDefault * Disable 2008 DXR test * Update 1000_RaytracingQualityKeyword_Indirect.png.meta Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> Co-authored-by: NetteVI <nette.vi@gmail.com> Co-authored-by: Vic Cooper <63712500+Vic-Cooper@users.noreply.github.com> Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com>
JulienIgnace-Unity
added a commit
that referenced
this pull request
Aug 17, 2021
* Opt-out of builtin auto generation of ambient probe/reflection probe * Update changelog # Conflicts: # com.unity.render-pipelines.high-definition/CHANGELOG.md # com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/HDRenderPipeline.cs
JulienIgnace-Unity
added a commit
that referenced
this pull request
Aug 31, 2021
…e. (#4324) (#5360) * Opt-out of builtin auto baking of ambient/reflection probe. (#4324) * Opt-out of builtin auto generation of ambient probe/reflection probe * Update changelog # Conflicts: # com.unity.render-pipelines.high-definition/CHANGELOG.md # com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/HDRenderPipeline.cs * Updated min version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Opt-out of builtin auto baking of ambient/reflection probe.
This caused some issue when baking in HDRP.
https://fogbugz.unity3d.com/f/cases/1313990/
Testing status
Tested the repro step in the fogbugz case