Added DOTS_INSTANCING_ON variants to the "HDRP/Decal" shader #4284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rt mesh decals using it in the Hybrid Renderer.
sebastienlagarde
approved these changes
Apr 22, 2021
sebastienlagarde
added a commit
that referenced
this pull request
Apr 22, 2021
…mesh decals using it in the Hybrid Renderer. (#4284)pp
sebastienlagarde
added a commit
that referenced
this pull request
Apr 22, 2021
* Merge Hd/bugfix #4265 * fix compil issue * fix compil issue * Fix shader warning when using Lanczos upsampling (#4280) * Updated ray tracing settings and added it to the table of contents (#4279) * Added DOTS_INSTANCING_ON variants to the "HDRP/Decal" shader to surt mesh decals using it in the Hybrid Renderer. (#4284)pp * Update decal stress test reference screenshots for vulkan Co-authored-by: Pavlos Mavridis <pavlos.mavridis@unity3d.com> Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>
sebastienlagarde
pushed a commit
that referenced
this pull request
Apr 30, 2021
sebastienlagarde
added a commit
that referenced
this pull request
May 1, 2021
* [10.x.x HDRP] Fix issue with raytracing resources not properly initialize (#4268) * draft * Fix build DXR * Match behavior with the one in master * Updated ray tracing settings and added it to the table of contents (#4279) * Updated ray tracing settings and added it to the toc * Removed hyphens from rtss toc entry * Fix shader warning when using Lanczos upsampling (#4280) * Added DOTS_INSTANCING_ON variants to the "HDRP/Decal" shader #4284 * [HDRP] Fp16_PPAlpha Panini projection, Motion Blur test and moved other Fp16Alpha scenes to one #4290 * [HDRP] Fix undo of some properties on light editor #4293 * Opt-out of builtin auto baking of ambient/reflection probe. #4324 * Revert "Opt-out of builtin auto baking of ambient/reflection probe. #4324" This reverts commit 719e835. * Hd/redo fix inputregistering domainreload (#4358) * Update InputRegistering.cs * Remove asset modification if InputSystem package is in use * Prevent missuse of InputRegistering while InputSystem package is in use * cleaning * more cleaning * Update code to use Next instead of GetArrayElementAtIndex * Fix strange out of range error Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> Co-authored-by: Pavlos Mavridis <pavlos.mavridis@unity3d.com> Co-authored-by: Andrew Saraev <67020478+AndrewSaraevUnity@users.noreply.github.com> Co-authored-by: TomasKiniulis <50582134+TomasKiniulis@users.noreply.github.com> Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com> Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> Co-authored-by: Remi Slysz <40034005+RSlysz@users.noreply.github.com>
AndrewSaraevUnity
added a commit
that referenced
this pull request
May 4, 2021
* [HDRP] Make Decal shader compatible with SRP batcher (#3806) * Fix SRP batcher with decal * Update CHANGELOG.md * Update CHANGELOG.md (cherry picked from commit 5a88bb8) * Added DOTS_INSTANCING_ON variants to the "HDRP/Decal" shader to support mesh decals using it in the Hybrid Renderer. (#4284) (cherry picked from commit fa2ff6e) * [2020.2] [10.x.x] [Bugfix 1296776] Enforce SRP Batcher and Hybrid renderer compatibility by always using a consolidated property list (#3577) * Make all passes in a subshader use the same HLSL proeprty declarations * Adding changelog * Better fix for Targets accessing the current blocks (cherry picked from commit 26a1096) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> Co-authored-by: Chris Tchou <ctchou@unity3d.com>
pastasfuture
pushed a commit
that referenced
this pull request
Aug 20, 2021
* [HDRP] Make Decal shader compatible with SRP batcher (#3806) * Fix SRP batcher with decal * Update CHANGELOG.md * Update CHANGELOG.md (cherry picked from commit 5a88bb8) * Added DOTS_INSTANCING_ON variants to the "HDRP/Decal" shader to support mesh decals using it in the Hybrid Renderer. (#4284) (cherry picked from commit fa2ff6e) Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
pastasfuture
pushed a commit
that referenced
this pull request
Sep 15, 2021
* [HDRP] Make Decal shader compatible with SRP batcher (#3806) * Fix SRP batcher with decal * Update CHANGELOG.md * Update CHANGELOG.md (cherry picked from commit 5a88bb8) * Added DOTS_INSTANCING_ON variants to the "HDRP/Decal" shader to support mesh decals using it in the Hybrid Renderer. (#4284) (cherry picked from commit fa2ff6e) Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
mohammad22
pushed a commit
that referenced
this pull request
Mar 2, 2022
* [HDRP] Make Decal shader compatible with SRP batcher (#3806) * Fix SRP batcher with decal * Update CHANGELOG.md * Update CHANGELOG.md (cherry picked from commit 5a88bb8) * Added DOTS_INSTANCING_ON variants to the "HDRP/Decal" shader to support mesh decals using it in the Hybrid Renderer. (#4284) (cherry picked from commit fa2ff6e) Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist for PR maker
need-backport-*label. After you backport the PR, the label changes tobackported-*.CHANGELOG.mdfile.Purpose of this PR
This adds DOTS_INSTANCING_ON variants to the "HDRP/Decal" shader passes used to render mesh decals, which allows them to be rendered with Hybrid Renderer V2.
Testing status
Tested manually with a SubScene in the editor 2021.2.0a14.1979 with Hybrid Renderer 0.11.0-preview.42.
Comments to reviewers
This is mainly required in 2020.2/partner/staging branch but since this change doesn't depend on the partner editor it might be better to backport it instead of forward-porting it later.