Skip to content

Fixed an issue where runtime debug window UI would leak game objects. #4337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 27, 2021
Merged

Fixed an issue where runtime debug window UI would leak game objects. #4337

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a9bab6b
Fixed an issue where runtime debug window UI would leak game objects.
JulienIgnace-Unity Apr 27, 2021
b896597
Update changelog
JulienIgnace-Unity Apr 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions com.unity.render-pipelines.core/Runtime/Debugging/Prefabs/Scripts/DebugUIHandlerBitField.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
namespace UnityEngine.Rendering.UI
{
/// <summary>
/// DebugUIHandler for Bitfield widget. Require the enum to have a None field set to 0 in it's values.
/// DebugUIHandler for Bitfield widget. Require the enum to have a None field set to 0 in its values.
/// </summary>
public class DebugUIHandlerBitField : DebugUIHandlerWidget
{
Expand Down Expand Up @@ -45,9 +45,11 @@ internal override void SetWidget(DebugUI.Widget widget)
}
;

// Destroy the remaining toggles outside of the range of the displayed enum.
for (; toggleIndex < toggles.Count; ++toggleIndex)
{
toggles[toggleIndex].transform.SetParent(null);
CoreUtils.Destroy(toggles[toggleIndex].gameObject);
toggles[toggleIndex] = null;
}
}

Expand Down
1 change: 1 addition & 0 deletions com.unity.render-pipelines.high-definition/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fixed LightCluster debug view for ray tracing.
- Fixed issue with RAS build fail when LOD was missing a renderer
- Fixed an issue where sometime a docked lookdev could be rendered at zero size and break.
- Fixed an issue where runtime debug window UI would leak game objects.

### Changed
- Changed Window/Render Pipeline/HD Render Pipeline Wizard to Window/Rendering/HDRP Wizard
Expand Down