Skip to content

Conversation

rjonaitis
Copy link
Contributor

Guide : https://github.com/Unity-Technologies/Graphics/blob/master/.github/pr-read.png.md

Display Addon : https://userstyles.org/styles/182991/unity-graphics-pr-readme

Purpose of this PR

Backport of #375 Adding adaptive performance as optional dependency and hooking up CameraData/RenderingData patching from AP settings.

Testing status

Manual Tests

Boat attack demo 2020.1 with URP 8.x with adaptive performance enabled/disabled

Automated Tests

What did you setup? (Add a screenshot or the reference image of the test please)

Links

Yamato: (Select your branch) https://yamato.prd.cds.internal.unity3d.com/jobs/902-Graphics

Any test projects or documents to go with this to help reviewers?

Comments to reviewers

Notes for the reviewers you have assigned.

@rjonaitis rjonaitis requested a review from phi-lira May 15, 2020 15:42
@rjonaitis rjonaitis requested a review from a team as a code owner May 15, 2020 15:42
@odbb odbb self-requested a review May 15, 2020 19:05
Copy link
Contributor

@phi-lira phi-lira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please add docs, same as the #375
#375 has to land before this backport.

@phi-lira
Copy link
Contributor

Missing docs from the on in master.

@phi-lira
Copy link
Contributor

Send me a slack DM when done and I will merge straight away.

@phi-lira phi-lira merged commit 159dfa8 into 8.x.x/release May 28, 2020
@phi-lira phi-lira deleted the 8.x.x/add-adaptive-performance branch May 28, 2020 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants