[8.x.x Backport] Fixes for issue with Default shader and material not available when Models are imported at project startup. #515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eh-unity
approved these changes
Jul 6, 2020
| #if UNITY_EDITOR | ||
| static readonly string[] s_ShaderGUIDs = | ||
| { | ||
| "933532a4fcc9baf4fa0491de14d08ed7", |
There was a problem hiding this comment.
This looks very manual and therefore brittle. Could we have symbolic constants or generate this automatically?
| using UnityEditorInternal; | ||
| #endif | ||
| using System.ComponentModel; | ||
| using System.Linq; |
There was a problem hiding this comment.
Can we use Linq? How does that perform in practice?
| int index = (int)id; | ||
| if (index < 0 && index >= (int)ShaderPathID.Count) | ||
| { | ||
| Debug.LogError("Trying to access universal shader path out of bounds"); |
There was a problem hiding this comment.
Should print params 'index' and 'count', so there's no need to debug to see what they were.
…Asset-loadAndForget
|
Yamato was green before a changelog fix. |
ellioman
deleted the
8.x.x/backports/urp-editorResourcesAsset-loadAndForget
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Backport of #339