[HDRP] Make custom post process template work and use cmd.Blit by defaukt #5202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alelievr
requested review from
a team,
FrancescoC-unity,
Vic-Cooper and
sebastienlagarde
|
Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed. HDRP Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure. |
FrancescoC-unity
approved these changes
Jul 22, 2021
sebastienlagarde
approved these changes
Jul 22, 2021
Reviewed the changes in this PR and made some small improvements to this section.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Updated the custom post-processes template to use cmd.Blit instead of HDUtils.DrawFullscreen which is more intuitive for users.
Also, the custom PP shader template was not working with cmd.Blit because of the missing Property scope in the shader and mismatching source texture name.
I also updated the doc about the usage of cmd.Blit and HDUtils.DrawFullscreen
Testing status
Tested that the greyscale example in our doc works as expected with cmd.Blit. Also replaced one of the custom post-process in our test project to use Blit() instead of HDUtils.DrawFullscreen.
https://yamato.cds.internal.unity3d.com/jobs/902-Graphics/tree/hd%252Ffix%252Fcustom-post-process-blit/.yamato%252Fall-hdrp.yml%2523PR_HDRP_trunk/7800994/job